Add more CI to GW-CI #1365
Add more CI to GW-CI #1365
Conversation
This reverts commit e024564.
|
@CoryMartin-NOAA @RussTreadon-NOAA @danholdaway @guillaumevernieres OK, I think this PR is now ready for final review and merger. I made some additional changes:
|
DavidNew-NOAA
requested review from
guillaumevernieres,
CoryMartin-NOAA and
danholdaway
There was a problem hiding this comment.
Thanks @DavidNew-NOAA. How long does it take to run all the ctests now? Not including the code building?
|
@danholdaway Let me run them all one more time to give you an exact answer |
DavidNew-NOAA
dismissed stale reviews from danholdaway and guillaumevernieres
via
0302bee
|
Let me run the test_gdasapp tests one more time, just for certainty. Then I'll merge |
|
I broke something somewhere, causing all |
|
@danholdaway My last run of the 119 |
| set(pslot "GFSv17-3DVAR-C384mx025") | ||
| set(YAML_PATH ${HOMEgfs}/ci/cases/gfsv17/${pslot}.yaml) |
There was a problem hiding this comment.
I am trying to run this set of tests, and it can't find the GFSv17-3DVAR-C384mx025.yaml in global-workflow/ci/cases/gfsv17. I don't see this file on develop, and I don't see it in NOAA-EMC/global-workflow#3120. What am I missing? (I have not yet tried to run with NOAA-EMC/global-workflow#3120)
There was a problem hiding this comment.
@shlyaeva Yeah, that was a mistake on my part. I assumed the GFSv17 test name had the same naming convention as the low resolution marine CI. Thanks for pointing this out, I'll make a bugfix PR tomorrow morning.
There was a problem hiding this comment.
Oh good, thank you for the clarification! I am still figuring out how to run things, so I wasn't sure whether I missed something.
…est (#3120) This PR is a companion to NOAA-EMC/GDASApp#1365 It turns ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA``` into a regression test using the JEDI application testing feature. This feature is turned on using the new ```DO_TEST_MODE``` parameter added to ```config.base``` in GW PR [#3115](#3115). This parameter is set to ```"YES"``` in the yaml defaults for the JEDI-based CI tests in GW. The motivation for this PR is a need to catch changes in JEDI which alter the outputs of our applications. --------- Co-authored-by: CoryMartin-NOAA <[email protected]> Co-authored-by: RussTreadon-NOAA <[email protected]>
This PR is a companion to GW PR #3120.
It does a couple things:
C96C48_hybatmDA,C96C48_ufs_hybatmDA,C96C48_hybatmaerosnowDA,C48mx500_3DVarAOWCDA, andC48mx500_hybAOWCDA.C96C48_ufs_hybatmDAandC48mx500_3DVarAOWCDA, so that we're actually testing the output.CMakeCache.txtfile and re-running make. This will allow us to use these tests in nightly testing.test/gw-ci/CMakeLists.txtis refactored quite a bit.The primary motivation for this PR is that we can run CI for our nightly testing of GDASApp. Also, anyone with a PR can easily do CI testing through CTests.