Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena crawler #995

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Athena crawler #995

merged 8 commits into from
Oct 4, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 3, 2024

🤔 Why?

To extract tables, views, and queries in Athena

🤓 What?

  • Extract tables
  • Extract query logs

🧪 Tested?

Ingest MCEs to dev instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon marked this pull request as ready for review October 3, 2024 08:01
Copy link

github-actions bot commented Oct 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12977 11614 90% 85% 🟢

New Files

File Coverage Status
metaphor/athena/config.py 100% 🟢
metaphor/athena/extractor.py 93% 🟢
metaphor/athena/models.py 100% 🟢
TOTAL 98% 🟢

Modified Files

No covered modified files...

updated for commit: 80ea13e by action🐍

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (00d72f9) to head (80ea13e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/athena/extractor.py 93.25% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
+ Coverage   89.42%   89.49%   +0.07%     
==========================================
  Files         196      199       +3     
  Lines       12827    12977     +150     
==========================================
+ Hits        11470    11614     +144     
- Misses       1357     1363       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a high leve. @usefulalgorithm pls take a closer look.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

metaphor/athena/extractor.py Outdated Show resolved Hide resolved
metaphor/athena/extractor.py Outdated Show resolved Hide resolved
metaphor/athena/extractor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@elic-eon elic-eon merged commit 2006bde into main Oct 4, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-19712/athena-crawler branch October 4, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants