Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter is not working in athena crawler #1008

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 16, 2024

🤔 Why?

Crawler filter is not implemented in #995

🤓 What?

  • Add filter

🧪 Tested?

Unit test

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13023 11625 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/athena/extractor.py 94% 🟢
TOTAL 94% 🟢

updated for commit: aa917a7 by action🐍

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.26%. Comparing base (a34d8e5) to head (aa917a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1008   +/-   ##
=======================================
  Coverage   89.25%   89.26%           
=======================================
  Files         200      200           
  Lines       13012    13023   +11     
=======================================
+ Hits        11614    11625   +11     
  Misses       1398     1398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon merged commit 8ee8f17 into main Oct 16, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29361/filter-is-not-working-in-athena-crawler branch October 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants