Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29051] MongoDB crawler #991

Merged
merged 13 commits into from
Oct 1, 2024

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

This is the implementation of the MongoDB crawler.

🤓 What?

  • Implemented the MongoDB crawler.
  • Added MongoDB crawler readme.
  • Added tests.

🧪 Tested?

  • Added unit test
    • This test the whole connector by setting up a MongoDB container, importing some sample data from MongoDB's official sample data, and running the crawler against the container.
  • Crawler was run locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Sep 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12806 11456 89% 85% 🟢

New Files

File Coverage Status
metaphor/common/infer_schema.py 94% 🟢
metaphor/mongodb/config.py 92% 🟢
metaphor/mongodb/extractor.py 92% 🟢
TOTAL 93% 🟢

Modified Files

File Coverage Status
metaphor/dbt/artifact_parser.py 93% 🟢
metaphor/dbt/cloud/parser/dbt_test_parser.py 91% 🟢
metaphor/metabase/extractor.py 85% 🟢
metaphor/notion/extractor.py 94% 🟢
TOTAL 91% 🟢

updated for commit: 05195b1 by action🐍

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 92.26519% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (f5c453b) to head (05195b1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/common/infer_schema.py 94.31% 5 Missing ⚠️
metaphor/mongodb/extractor.py 92.18% 5 Missing ⚠️
metaphor/mongodb/config.py 92.00% 2 Missing ⚠️
metaphor/dbt/artifact_parser.py 0.00% 1 Missing ⚠️
metaphor/notion/extractor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   89.40%   89.45%   +0.05%     
==========================================
  Files         193      196       +3     
  Lines       12629    12806     +177     
==========================================
+ Hits        11291    11456     +165     
- Misses       1338     1350      +12     
Flag Coverage Δ
89.45% <92.26%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM
Great work!

metaphor/mongodb/README.md Outdated Show resolved Hide resolved
metaphor/mongodb/extractor.py Show resolved Hide resolved
metaphor/common/infer_schema.py Outdated Show resolved Hide resolved
Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usefulalgorithm usefulalgorithm merged commit c58fb73 into main Oct 1, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-29051/mongodb-crawler branch October 1, 2024 04:24
@elic-eon elic-eon mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants