Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract iceberg table #993

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 1, 2024

🤔 Why?

To support the Snowflake iceberg table.

🤓 What?

  • Update the readme to give the crawler permission to extract the iceberg tables.
  • Fill extra information for iceberg table

🧪 Tested?

Create an iceberg table and the crawler can extract it.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon force-pushed the scotthuang/sc-29053/snowflake-iceberg-support branch from 183f5f3 to dba353e Compare October 1, 2024 10:05
Copy link

github-actions bot commented Oct 1, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12827 11470 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/extractor.py 84% 🟢
TOTAL 84% 🟢

updated for commit: 8423e2a by action🐍

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.42%. Comparing base (460066e) to head (8423e2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/snowflake/extractor.py 60.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   89.45%   89.42%   -0.04%     
==========================================
  Files         196      196              
  Lines       12809    12827      +18     
==========================================
+ Hits        11458    11470      +12     
- Misses       1351     1357       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon marked this pull request as ready for review October 1, 2024 11:52
…b.com:MetaphorData/connectors into scotthuang/sc-29053/snowflake-iceberg-support
@elic-eon elic-eon requested a review from mars-lan October 1, 2024 16:57
@elic-eon elic-eon merged commit 00d72f9 into main Oct 2, 2024
4 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29053/snowflake-iceberg-support branch October 2, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants