Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source_info.main_url instead of crafting workbook url in tableau extractor #941

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Should use source_info.main_url for embedded datasource url instead.

🤓 What?

As titled.

🧪 Tested?

Tested locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Aug 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11723 10420 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/tableau/extractor.py 87% 🟢
TOTAL 87% 🟢

updated for commit: 7c9ea1d by action🐍

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (fa40d88) to head (7c9ea1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         182      182           
  Lines       11723    11723           
=======================================
  Hits        10420    10420           
  Misses       1303     1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm enabled auto-merge (squash) August 7, 2024 03:55
Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to bump the version again. The other PR is merged.

@usefulalgorithm usefulalgorithm enabled auto-merge (squash) August 7, 2024 07:28
@usefulalgorithm usefulalgorithm merged commit 62ce241 into main Aug 7, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the use_source_info_url_instead_of_hand_crafting branch August 7, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants