Skip to content

Commit

Permalink
Use source_info.main_url instead of crafting workbook url in tableau …
Browse files Browse the repository at this point in the history
…extractor (#941)

* Use source_info.main_url instead of crafting workbook url in tableau extractor

* bump version

---------

Co-authored-by: Scott Ssuyi Huang <[email protected]>
  • Loading branch information
usefulalgorithm and elic-eon authored Aug 7, 2024
1 parent fa40d88 commit 62ce241
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion metaphor/tableau/extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,11 @@ def _parse_workbook_query_response(
custom_sql_source.account if custom_sql_source else None
),
source_datasets=source_datasets or None,
url=f"{self._base_url}/workbooks/{workbook.vizportalUrlId}",
url=(
dashboard.source_info.main_url
if dashboard.source_info
else None
),
),
entity_upstream=(
EntityUpstream(source_entities=source_datasets)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "metaphor-connectors"
version = "0.14.70"
version = "0.14.71"
license = "Apache-2.0"
description = "A collection of Python-based 'connectors' that extract metadata from various sources to ingest into the Metaphor app."
authors = ["Metaphor <[email protected]>"]
Expand Down

0 comments on commit 62ce241

Please sign in to comment.