Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize dbt owner email address #938

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Normalize dbt owner email address #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaphor/common/entity_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def to_person_entity_id(email: str) -> EntityId:
"""
return EntityId(
EntityType.PERSON,
PersonLogicalID(email=email),
PersonLogicalID(email=email.lower()),
)


Expand Down
45 changes: 39 additions & 6 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "metaphor-connectors"
version = "0.14.66"
version = "0.14.67"
license = "Apache-2.0"
description = "A collection of Python-based 'connectors' that extract metadata from various sources to ingest into the Metaphor app."
authors = ["Metaphor <[email protected]>"]
Expand Down Expand Up @@ -33,6 +33,7 @@ google-cloud-bigquery = { version = "^3.25.0", optional = true }
google-cloud-logging = { version = "^3.5.0", optional = true }
gql = { extras = ["requests"], version = "^3.4.1", optional = true }
grpcio-tools = { version = "^1.59.3", optional = true }
httpx = "^0.27.0"
jsonschema = "^4.18.6"
lkml = { version = "^1.3.1", optional = true }
llama-index = { version = "^0.10.19", optional = true }
Expand Down Expand Up @@ -70,6 +71,7 @@ thoughtspot_rest_api_v1 = { version = "1.5.3", optional = true }
thrift = { version = "^0.16.0", optional = true }
thrift-sasl = { version = "^0.4.3", optional = true }
trino = { version = "^0.327.0", optional = true }
trio = "^0.26.1"

[tool.poetry.extras]
all = [
Expand All @@ -87,6 +89,7 @@ all = [
"google-cloud-logging",
"gql",
"grpcio-tools",
"httpx",
"lkml",
"looker-sdk",
"llama-index",
Expand Down Expand Up @@ -121,7 +124,7 @@ bigquery = ["google-cloud-bigquery", "google-cloud-logging", "sql-metadata"]
confluence = ["llama-index", "llama-index-embeddings-azure-openai", "llama-index-readers-confluence"]
datafactory = ["azure-identity", "azure-mgmt-datafactory"]
datahub = ["gql"]
dbt = []
dbt = ["httpx"]
hive = ["pyhive", "sasl", "thrift", "thrift-sasl"]
kafka = ["confluent-kafka", "avro", "grpcio-tools"]
looker = ["GitPython", "lkml", "looker-sdk"]
Expand Down
2 changes: 1 addition & 1 deletion tests/dbt/data/trial_v4/expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"meta": [
{
"key": "owner",
"value": "\"[email protected]\""
"value": "\"[email protected]\""
},
{
"key": "pii",
Expand Down
2 changes: 1 addition & 1 deletion tests/dbt/data/trial_v4/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"database": null,
"tags": [],
"meta": {
"owner": "[email protected]",
"owner": "[email protected]",
"pii": true
},
"materialized": "view",
Expand Down
Loading