Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize dbt owner email address #938

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Aug 5, 2024

🤔 Why?

Email for a person in logical ID should always be normalized to lower cases.

🤓 What?

As titled. Also added the dependencies missed in #926.

🧪 Tested?

Unit tests.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan enabled auto-merge (squash) August 5, 2024 15:50
Copy link

github-actions bot commented Aug 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11723 10420 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/entity_id.py 100% 🟢
TOTAL 100% 🟢

updated for commit: f1bb4f6 by action🐍

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (8971b11) to head (f1bb4f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         182      182           
  Lines       11723    11723           
=======================================
  Hits        10420    10420           
  Misses       1303     1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan merged commit ae0b95b into main Aug 6, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-27933/normalize-dbt-owner-email-address branch August 6, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants