Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account_usage config to query a alternate schema #936

Merged

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Aug 4, 2024

🤔 Why?

Granting access to the entire SNOWFLAKE database may not always be desirable. The connector should be able to query from a different schema that mirrors the minimally needed views (QUERY_HISTORY, ACCESS_HISTORY, TAG_REFERENCES).

🤓 What?

As titled.

🧪 Tested?

Verified against a production instance with mirrored views.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan enabled auto-merge (squash) August 4, 2024 12:38
Copy link

github-actions bot commented Aug 4, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11723 10420 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/config.py 100% 🟢
metaphor/snowflake/extractor.py 85% 🟢
TOTAL 92% 🟢

updated for commit: a7d41df by action🐍

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (d966e3a) to head (a7d41df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         182      182           
  Lines       11721    11723    +2     
=======================================
+ Hits        10418    10420    +2     
  Misses       1303     1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mars-lan mars-lan merged commit 6c91a1a into main Aug 4, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-27930/add-config-to-read-snowflake-account-usage branch August 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants