Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use account_usage_schema config in all places #952

Merged

Conversation

mars-lan
Copy link
Contributor

🤔 Why?

#936 added the config but missed a few spots.

🤓 What?

As titled.

🧪 Tested?

Verified end-to-end against a production instance with mirrored ACCOUNT_USAGE schema and privilege to read SNOWFLAKE db revoked.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan marked this pull request as ready for review August 16, 2024 12:52
Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11788 10473 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/config.py 100% 🟢
metaphor/snowflake/extractor.py 85% 🟢
metaphor/snowflake/lineage/extractor.py 68% 🟢
metaphor/snowflake/utils.py 63% 🟢
TOTAL 79% 🟢

updated for commit: 6f9165e by action🐍

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (59c5856) to head (6f9165e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files         182      182           
  Lines       11787    11788    +1     
=======================================
+ Hits        10472    10473    +1     
  Misses       1315     1315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mars-lan mars-lan merged commit 46fca04 into main Aug 16, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-28105/respect-snowflake-crawler-account-usage-schema branch August 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants