Version v11.14.5 #24342

danjm · 2024-05-02T10:14:16Z

Testing instructions for 8c9ed8f:

Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h
Try minting the nft
Simulation should work and show the nft in the "You receive" section.

Testing instructions for 2d9f5f7:

Setup metamask so that it will send metrics events. This requires building with the SEGMENT_WRITE_KEY set, and setting "Participate in MetaMetrics" to true.
Open the background console and the network tab
Go through the send flow and confirm a transaction
Once it is no longer pending and is confirmed, you should see a network request to segment, with "Transaction Finalized" in the payload

Testing instructions for 949e733:

Trigger any number of transactions
Do not see "Edit" in header
Open MetaMask, manually start a send, see the "Edit" button

github-actions · 2024-05-02T10:14:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-05-02T10:40:49Z

Builds ready [2079594]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (712 ± 469 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	147	99	22	10
		domContentLoaded	9	58	20	11	5
		load	51	2521	712	977	469
		domInteractive	9	58	20	11	5

cherry-pick fix NFT mint simulations by updating transaction-controller (#24306) to v11.14.5 NOTE: This commit is not a cherry-pick of an existing commit. To ensure peer dependencies were met, yarn add @metamask/transaction-controller@^28.1.1 was run against v11.14.5 and the results were committed. --------- Co-authored-by: MetaMask Bot <[email protected]>

socket-security · 2024-05-02T14:46:48Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network Transitive: filesystem	`+8`	3.88 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

metamaskbot · 2024-05-02T15:08:15Z

Builds ready [8c9ed8f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1755 ± 899 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	302	125	59	28
		domContentLoaded	10	115	27	22	11
		load	49	4584	1755	1873	899
		domInteractive	10	115	27	22	11

…on confirmation (#24338) (#24353) Cherry-picks 9a7f82a (#24338) to v11.14.5

…transactions (#24334) (#24354) Cherry picks 4a1853c (#24322) to v11.14.5 Co-authored-by: David Walsh <[email protected]>

danjm · 2024-05-02T18:20:37Z

@SocketSecurity ignore-all

metamaskbot · 2024-05-02T18:56:41Z

Builds ready [646ea2e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (605 ± 611 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	153	96	18	9
		domContentLoaded	14	32	21	5	2
		load	54	4194	605	1273	611
		domInteractive	14	31	21	5	2

v11.14.5

2079594

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 2, 2024

metamaskbot added the release-11.14.5 Issue or pull request that will be included in release 11.14.5 label May 2, 2024

metamaskbot mentioned this pull request May 2, 2024

cherry-pick fix NFT mint simulations to v11.14.5 #24350

Merged

danjm and others added 2 commits May 2, 2024 15:43

fix (cherry-pick): "Transaction Finalized" metrics event on transacti…

2d9f5f7

…on confirmation (#24338) (#24353) Cherry-picks 9a7f82a (#24338) to v11.14.5

fix (cherry-pick): Fix #24322 - Disable edits for all dapp initiated …

949e733

…transactions (#24334) (#24354) Cherry picks 4a1853c (#24322) to v11.14.5 Co-authored-by: David Walsh <[email protected]>

Update changelog for v11.14.5

646ea2e

danjm marked this pull request as ready for review May 2, 2024 19:32

danjm requested review from a team as code owners May 2, 2024 19:32

danjm temporarily deployed to desktop May 2, 2024 19:32 — with GitHub Actions Inactive

danjm merged commit ba27c66 into master May 2, 2024
71 of 73 checks passed

danjm deleted the Version-v11.14.5 branch May 2, 2024 19:32

github-actions bot locked and limited conversation to collaborators May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version v11.14.5 #24342

Version v11.14.5 #24342

danjm commented May 2, 2024 •

edited

Loading

github-actions bot commented May 2, 2024

metamaskbot commented May 2, 2024

socket-security bot commented May 2, 2024 •

edited

Loading

metamaskbot commented May 2, 2024

danjm commented May 2, 2024

metamaskbot commented May 2, 2024

Version v11.14.5 #24342

Version v11.14.5 #24342

Conversation

danjm commented May 2, 2024 • edited Loading

github-actions bot commented May 2, 2024

metamaskbot commented May 2, 2024

socket-security bot commented May 2, 2024 • edited Loading

metamaskbot commented May 2, 2024

danjm commented May 2, 2024

metamaskbot commented May 2, 2024

danjm commented May 2, 2024 •

edited

Loading

socket-security bot commented May 2, 2024 •

edited

Loading