Fix #24322 - Disable edits for all dapp initiated transactions

[darkwing]

Description

Ensures only transactions started within MetaMask are editable

Related issues

Fixes: #24322

Manual testing steps

1. Go to the test dapp (https://metamask.github.io/test-dapp/)
2. Trigger any number of transactions
3. Do not see "Edit" in header
4. Open MetaMask, manually start a send, see the "Edit" button

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sleepytanya]

I don't see 'Edit' button for dapp initiated transactions:

noEdit.mov

[sleepytanya]

Latest commit ef8dd7c, looks great!
No 'Edit' option for dapp initiated simple transactions, NFT safeTransferFrom and for ERC20 transferFrom:

2.mov

Send transaction initiated from within the wallet has "Edit" button:

Screen.Recording.2024-05-01.at.22.20.44.mov

[metamaskbot]

Builds ready [a48d8f0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (998 ± 614 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	109	83	12	6
		domContentLoaded	10	14	11	1	1
		load	49	3040	998	1278	614
		domInteractive	10	14	11	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 66 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.32%. Comparing base (f2ec444) to head (a48d8f0).
Report is 52 commits behind head on develop.

Files	Patch %	Lines
...-header/confirm-page-container-header.component.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24334   +/-   ##
========================================
  Coverage    67.32%   67.32%           
========================================
  Files         1276     1276           
  Lines        49739    49740    +1     
  Branches     12925    12926    +1     
========================================
+ Hits         33482    33483    +1     
  Misses       16257    16257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [a48d8f0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (998 ± 614 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	109	83	12	6
		domContentLoaded	10	14	11	1	1
		load	49	3040	998	1278	614
		domInteractive	10	14	11	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 66 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [a48d8f0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (998 ± 614 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	109	83	12	6
		domContentLoaded	10	14	11	1	1
		load	49	3040	998	1278	614
		domInteractive	10	14	11	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 66 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [7c77c22]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (444 ± 421 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	57	305	91	53	25
		domContentLoaded	8	94	19	21	10
		load	45	2709	444	876	421
		domInteractive	8	94	19	21	10

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 66 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-11.14.5 on PR. Adding release label release-11.14.5 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.14.5.