fix: "Transaction Finalized" metrics event on transaction confirmation

[danjm]

0de97df brought in a number of breaking changes as it updated the transaction controller.

One of the breaking changes was changing the shape of the object included in the event when a transaction is confirmed:

(https://github.com/MetaMask/core/pull/3827/files#diff-96bc10c64242a8e23f5835532988319189239bdf40f556b86199dcbcc41c7bfcL1353-R1646)

The handleTransactionConfirmed handler in app/scripts/lib/transaction/metrics.ts was not updated to accommodate this difference. So its if (!transactionEventPayload.transactionMeta) { condition was always being hit, and the function was returning early. This PR corrects that, and thereby fixes the "Transaction Finalzied" event

Description

Related issues

Fixes: #24339

Manual testing steps

1. Setup metamask so that it will send metrics events. This requires building with the SEGMENT_WRITE_KEY set, and setting "Participate in MetaMetrics" to true.
2. Open the background console and the network tab
3. Go through the send flow and confirm a transaction
4. Once it is no longer pending and is confirmed, you should see a network request to segment, with "Transaction Finalized" in the payload

Screenshots/Recordings

tx-finalized-metrics.mp4

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[hjetpoluru]

I tested and see the 'Transaction Finalized' event for both the successful and failed transactions.

[metamaskbot]

Builds ready [756f043]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1097 ± 681 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	212	98	40	19
		domContentLoaded	9	109	23	26	12
		load	52	3803	1097	1419	681
		domInteractive	9	109	23	26	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 32 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.32%. Comparing base (945750d) to head (756f043).
Report is 7 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24338   +/-   ##
========================================
  Coverage    67.32%   67.32%           
========================================
  Files         1276     1276           
  Lines        49739    49739           
  Branches     12925    12925           
========================================
  Hits         33482    33482           
  Misses       16257    16257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcmire]

Seems like this one slipped through the cracks 😞 Fix makes sense to me.

[metamaskbot]

Missing release label release-11.14.5 on PR. Adding release label release-11.14.5 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.14.5.