[WIP] pydantic2 updates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Is there a blocker for this @gpetretto? Now atomate2 has updated (and is now adding many new workflows each release) I guess we need to catch up... I'll test this out and see if I run into any issues. |
These changes are included in the #37 I think. Do you think it would be good to merge it before anyway ? |
|
Indeed these changes are also included in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to make jobflow_remote compatible with pydantic version >=2.
In principle I tested and it seems to work correctly with the latest versions of jobflow and maggma. However, I prefer not to merge right away, as this will be incompatible with pydantic<2 and it would require updating the whole set of MP related packages. I started to open this PR in case anybody needs it or wants to review/test.