Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jobflow dependency #30

Closed
davidwaroquiers opened this issue Sep 29, 2023 · 1 comment · Fixed by #31
Closed

Jobflow dependency #30

davidwaroquiers opened this issue Sep 29, 2023 · 1 comment · Fixed by #31

Comments

@davidwaroquiers
Copy link
Member

I think we could now use the official jobflow repo. Or should we wait (e.g. because of pydantic v2 ?).

jobflow-remote/pyproject.toml

Line 29 in 92f9a57

"jobflow[strict] @ git+ssh://[email protected]/materialsproject/jobflow",

@gpetretto
Copy link
Contributor

Indeed with the latest jobflow release (0.1.14) it will be broken if #29 is not merged, as jobflow-remote will require pydantic<2 to work.
In case we should pin jobflow==0.1.13.

@ml-evs ml-evs mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the qtoolkit and jobflow PyPI packages, add direct pydantic dep ml-evs/jobflow-remote
2 participants
@davidwaroquiers @gpetretto