-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the qtoolkit and jobflow PyPI packages, add direct pydantic dep #31
Conversation
@gpetretto / @davidwaroquiers this would be helpful to merge before #29 is finished, then we can undo the changes after. (I also realise I do not have the power to request reviewers here... perhaps I could be added as a maintainer?) |
The current jobflow[strict] version pins pydantic to version 2.4.2. The latest jobflow version supporting pydantic <2 was 0.1.13. Maybe it would be better to also pin the jobflow requirement to that version? I am not sure if having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the comment on jobflow version wrt pydantic version. Not sure about it.
It could be pinned, but this seems like the lightest weight way of doing it -- all that #29 needs to do afterwards is lower pin pydantic~=2.0 and then jobflow>=0.1.14 will be used. Up to you if you'd rather pin jobflow too though! |
I guess @gpetretto you also mean whether it is worth even adding pydantic as a dependency, instead just going along with jobflow? I think as we are using specific pydantic code here, then it should definitely appear as a dependency, even if the |
If pip resolves the correct version of jobflow to use it is fine as it is. |
Closes #30
Related to #29