fix: multiline string cmd for prepare_apk #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MartinGonzalez Hello! Can I ask you to review this, MR? I found this one, when moved our Android building pipeline to some Windows nodes. |
MartinGonzalez
changed the title
MartinGonzalez
approved these changes
Jul 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
# 1.0.0 (2024-07-23) ### Bug Fixes * escape keystore_info params passed to bundletool ([3651593](3651593)) * fix usage URI instead of deprecated Kernel ([3198783](3198783)) * handle special characters ([4a80855](4a80855)) * Merge pull request [#17](#17) from christianEconify/fix/handle-special-characters ([dc65f58](dc65f58)) * multiline string cmd for prepare_apk ([#23](#23)) ([ceb9fe1](ceb9fe1)) * tests on pr ([dbea065](dbea065))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## [1.0.11](v1.0.10...v1.0.11) (2024-07-23) ### Bug Fixes * multiline string cmd for prepare_apk ([#23](#23)) ([ceb9fe1](ceb9fe1))
|
🎉 This issue has been resolved in version 1.0.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
If running the bundletool fastlane plugin on Windows cmd, you get an error -
The syntax of the command is incorrect.. The reason is that putting new lines in the ruby string creates new lines in the output, and this can lead to inconsistent run in some shells.When using
\we ensure that the resulting command is a single line.