fix: multiline string cmd for prepare_apk (#23)

If running the bundletool fastlane plugin on Windows cmd, you get an error - `The syntax of the command is incorrect.`. The reason is that putting new lines in the ruby string creates new lines in the output, and this can lead to inconsistent run in some shells. When using `\` we ensure that the resulting command is a single line. Co-authored-by: Vladyslav Androshchuk <[email protected]>
MartinGonzalez · Jul 23, 2024 · ceb9fe1 · ceb9fe1
1 parent 35bb3a3
commit ceb9fe1
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/fastlane/plugin/bundletool/actions/bundletool_action.rb b/lib/fastlane/plugin/bundletool/actions/bundletool_action.rb
@@ -120,9 +120,11 @@ def self.prepare_apk!(output_path, target_path)
           puts_important("Creating path #{target_dir_name} since does not exist")
           FileUtils.mkdir_p target_dir_name
         end
-        cmd = "mv \"#{output_path}\" \"#{@bundletool_temp_path}/output.zip\" &&
-        unzip \"#{@bundletool_temp_path}/output.zip\" -d \"#{@bundletool_temp_path}\" &&
-        mv \"#{@bundletool_temp_path}/universal.apk\" \"#{target_path}\""
+
+        cmd = "mv \"#{output_path}\" \"#{@bundletool_temp_path}/output.zip\" &&"\
+              "unzip \"#{@bundletool_temp_path}/output.zip\" -d \"#{@bundletool_temp_path}\" &&"\
+              "mv \"#{@bundletool_temp_path}/universal.apk\" \"#{target_path}\""
+
         Open3.popen3(cmd) do |_, _, stderr, wait_thr|
           exit_status = wait_thr.value
           raise stderr.read unless exit_status.success?