Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiline string cmd for prepare_apk #23

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: multiline string cmd for prepare_apk #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/fastlane/plugin/bundletool/actions/bundletool_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,11 @@ def self.prepare_apk!(output_path, target_path)
puts_important("Creating path #{target_dir_name} since does not exist")
FileUtils.mkdir_p target_dir_name
end
cmd = "mv \"#{output_path}\" \"#{@bundletool_temp_path}/output.zip\" &&
unzip \"#{@bundletool_temp_path}/output.zip\" -d \"#{@bundletool_temp_path}\" &&
mv \"#{@bundletool_temp_path}/universal.apk\" \"#{target_path}\""

cmd = "mv \"#{output_path}\" \"#{@bundletool_temp_path}/output.zip\" &&"\
"unzip \"#{@bundletool_temp_path}/output.zip\" -d \"#{@bundletool_temp_path}\" &&"\
"mv \"#{@bundletool_temp_path}/universal.apk\" \"#{target_path}\""

Open3.popen3(cmd) do |_, _, stderr, wait_thr|
exit_status = wait_thr.value
raise stderr.read unless exit_status.success?
Expand Down
Loading