Feat/questionnaire load version #892
Conversation
| <span>{dayjs(timestamp).format('YYYY-MM-DD HH:mm:ss')}</span> | ||
| </div> | ||
| <div className="first-letter:uppercase text-slate-400"> | ||
| <span className="italic" title={dayjs(timestamp).format('LLLL')}> | ||
| {dayjs(timestamp).fromNow()}, | ||
| </span>{' '} | ||
| par <span>{author}</span> | ||
| par{' '} | ||
| <a href={`https://trombi.insee.fr/${author}`} target="_blank"> |
There was a problem hiding this comment.
Not really fan to have a hard-coded link.
There was a problem hiding this comment.
True. I was lazy to add a new env var.
| <span>{dayjs(timestamp).format('YYYY-MM-DD HH:mm:ss')}</span> | ||
| </div> | ||
| <div className="first-letter:uppercase text-slate-400"> | ||
| <span className="italic" title={dayjs(timestamp).format('LLLL')}> | ||
| {dayjs(timestamp).fromNow()}, | ||
| </span>{' '} | ||
| par <span>{author}</span> | ||
| par{' '} |
There was a problem hiding this comment.
Would be nice to have a translated text here (i did not notice this before :-p)
| }: Readonly<ConfirmInlineProps>) { | ||
| return ( | ||
| <span className="text-lg"> | ||
| <span className="align-middle">{Dictionary.confirmQuestionMessage}</span>{' '} |
There was a problem hiding this comment.
After almost every div you add a {' '} for adding space. Don't you prefer to add margin ?
There was a problem hiding this comment.
That's added by Prettier. It's for when there is a space between two span elements separated by a new line. It has nothing to do with margins.
e.g.
I like spaghettis
is the same as
I like{' '}
spaghettis
There was a problem hiding this comment.
ok thanks, I never saw that 😄
There was a problem hiding this comment.
just a UI detail : the inline confirm seems to be really small compared to the rest of the versionDetail (particularly the check/xmark that are hard to click on)
There was a problem hiding this comment.
It was on purpose since it is an action that won't be used too much but we can change the style later on if it proves to be too annoying.
| <button className="btn-white" onClick={() => setConfirmLoad(true)}> | ||
| {Dictionary.load} | ||
| </button> | ||
| {confirmLoad ? ( |
There was a problem hiding this comment.
Here you never set confirmLoad when trying to load another version (you can display the confirm component on every versions). Is this done on purpose ?
There was a problem hiding this comment.
It's a bit more tricky to do so I thought it was good enough for now. Especially since we want to move the version thing into a tab instead of a modal (if we make the ui more modern) so we won't need this anymore in the long run. since we'll be able to confirm it through a modal.
(I decided to go for the inline confirm for now because I didn't like to open a modal in a modal...)
|
No description provided.