-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/questionnaire load version #892
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,65 @@ | ||
import { useState } from 'react'; | ||
|
||
import dayjs from 'dayjs'; | ||
import 'dayjs/locale/fr'; | ||
import localizedFormat from 'dayjs/plugin/localizedFormat'; | ||
import relativeTime from 'dayjs/plugin/relativeTime'; | ||
import { Clock } from 'iconoir-react'; | ||
|
||
import type { Version } from '@/models/versions'; | ||
import Dictionary from '@/utils/dictionary/dictionary'; | ||
import ConfirmInline from '@/widgets/inlineConfirm'; | ||
|
||
dayjs.locale('fr'); | ||
dayjs.extend(relativeTime); | ||
dayjs.extend(localizedFormat); | ||
|
||
interface VersionProps { | ||
isQuestionnaireModified?: boolean; | ||
version: Version; | ||
token: string; | ||
onLoad: () => void; | ||
} | ||
|
||
export default function VersionDetails({ version }: Readonly<VersionProps>) { | ||
export default function VersionDetails({ | ||
isQuestionnaireModified = false, | ||
version, | ||
onLoad, | ||
}: Readonly<VersionProps>) { | ||
const [confirmLoad, setConfirmLoad] = useState<boolean>(false); | ||
|
||
const { author, timestamp } = version; | ||
|
||
return ( | ||
<div className="grid grid-cols-[auto_1fr] gap-x-4"> | ||
<> | ||
<div className="inline-flex gap-3 items-center"> | ||
<Clock height={18} /> | ||
<Clock height={18} width={18} /> | ||
<span>{dayjs(timestamp).format('YYYY-MM-DD HH:mm:ss')}</span> | ||
</div> | ||
<div className="first-letter:uppercase text-slate-400"> | ||
<span className="italic" title={dayjs(timestamp).format('LLLL')}> | ||
{dayjs(timestamp).fromNow()}, | ||
</span>{' '} | ||
par <span>{author}</span> | ||
par{' '} | ||
<a href={`https://trombi.insee.fr/${author}`} target="_blank"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really fan to have a hard-coded link. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True. I was lazy to add a new env var. |
||
{author} | ||
</a> | ||
</div> | ||
<div className="inline-flex gap-3 items-center"> | ||
<button className="btn-white" onClick={() => setConfirmLoad(true)}> | ||
{Dictionary.load} | ||
</button> | ||
{confirmLoad ? ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here you never set confirmLoad when trying to load another version (you can display the confirm component on every versions). Is this done on purpose ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a bit more tricky to do so I thought it was good enough for now. Especially since we want to move the version thing into a tab instead of a modal (if we make the ui more modern) so we won't need this anymore in the long run. since we'll be able to confirm it through a modal. (I decided to go for the inline confirm for now because I didn't like to open a modal in a modal...) |
||
<ConfirmInline | ||
onConfirm={onLoad} | ||
onCancel={() => setConfirmLoad(false)} | ||
warningLabel={ | ||
isQuestionnaireModified | ||
? `${Dictionary.modificationsNotSaved}` | ||
: undefined | ||
} | ||
/> | ||
) : null} | ||
</div> | ||
</div> | ||
</> | ||
); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,19 @@ | ||
import { connect } from 'react-redux'; | ||
|
||
import { loadQuestionnaireVersion } from '../../../actions/app-state'; | ||
import Versions from '../components/Versions'; | ||
|
||
const mapStateToProps = (state) => ({ | ||
isQuestionnaireModified: state.appState.isQuestionnaireModified, | ||
questionnaire: state.appState.activeQuestionnaire, | ||
}); | ||
const mapDispatchToProps = { | ||
loadQuestionnaireVersion, | ||
}; | ||
|
||
const QuestionnaireListComponentsContainer = connect(mapStateToProps)(Versions); | ||
const QuestionnaireListComponentsContainer = connect( | ||
mapStateToProps, | ||
mapDispatchToProps, | ||
)(Versions); | ||
|
||
export default QuestionnaireListComponentsContainer; |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { expect, test } from 'vitest'; | ||
|
||
import { createDictionary, getLang } from './dictionary'; | ||
|
||
test(`should return the french version when the navigator.language is FR`, () => { | ||
expect(createDictionary('fr').welcome).toBe('Bienvenue dans POGUES'); | ||
}); | ||
|
||
test(`should return the english version when the navigator.language is EN`, () => { | ||
expect(createDictionary('en').welcome).toBe('Welcome to POGUES'); | ||
}); | ||
|
||
test.each([ | ||
['fr', 'fr'], | ||
['fr-FR', 'fr'], | ||
['de-DE', 'en'], | ||
])('getLang(%s) -> %s', (locale, expected) => { | ||
expect(getLang(locale)).toBe(expected); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a translated text here (i did not notice this before :-p)