-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/questionnaire load version #892
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,66 @@ | ||
import { useState } from 'react'; | ||
|
||
import dayjs from 'dayjs'; | ||
import 'dayjs/locale/fr'; | ||
import localizedFormat from 'dayjs/plugin/localizedFormat'; | ||
import relativeTime from 'dayjs/plugin/relativeTime'; | ||
import { Clock } from 'iconoir-react'; | ||
|
||
import type { Version } from '@/models/versions'; | ||
import Dictionary from '@/utils/dictionary/dictionary'; | ||
import { getEnvVar } from '@/utils/env'; | ||
import ConfirmInline from '@/widgets/inlineConfirm'; | ||
|
||
dayjs.locale('fr'); | ||
dayjs.extend(relativeTime); | ||
dayjs.extend(localizedFormat); | ||
|
||
interface VersionProps { | ||
isQuestionnaireModified?: boolean; | ||
version: Version; | ||
token: string; | ||
onLoad: () => void; | ||
} | ||
|
||
export default function VersionDetails({ version }: Readonly<VersionProps>) { | ||
export default function VersionDetails({ | ||
isQuestionnaireModified = false, | ||
version, | ||
onLoad, | ||
}: Readonly<VersionProps>) { | ||
const [confirmLoad, setConfirmLoad] = useState<boolean>(false); | ||
|
||
const { author, timestamp } = version; | ||
|
||
return ( | ||
<div className="grid grid-cols-[auto_1fr] gap-x-4"> | ||
<> | ||
<div className="inline-flex gap-3 items-center"> | ||
<Clock height={18} /> | ||
<Clock height={18} width={18} /> | ||
<span>{dayjs(timestamp).format('YYYY-MM-DD HH:mm:ss')}</span> | ||
</div> | ||
<div className="first-letter:uppercase text-slate-400"> | ||
<span className="italic" title={dayjs(timestamp).format('LLLL')}> | ||
{dayjs(timestamp).fromNow()}, | ||
</span>{' '} | ||
par <span>{author}</span> | ||
{Dictionary.by}{' '} | ||
<a href={`${getEnvVar('TROMBI_URL')}/${author}`} target="_blank"> | ||
{author} | ||
</a> | ||
</div> | ||
<div className="inline-flex gap-3 items-center"> | ||
<button className="btn-white" onClick={() => setConfirmLoad(true)}> | ||
{Dictionary.load} | ||
</button> | ||
{confirmLoad ? ( | ||
<ConfirmInline | ||
onConfirm={onLoad} | ||
onCancel={() => setConfirmLoad(false)} | ||
warningLabel={ | ||
isQuestionnaireModified | ||
? `${Dictionary.modificationsNotSaved}` | ||
: undefined | ||
} | ||
/> | ||
) : null} | ||
</div> | ||
</div> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,19 @@ | ||
import { connect } from 'react-redux'; | ||
|
||
import { loadQuestionnaireVersion } from '../../../actions/app-state'; | ||
import Versions from '../components/Versions'; | ||
|
||
const mapStateToProps = (state) => ({ | ||
isQuestionnaireModified: state.appState.isQuestionnaireModified, | ||
questionnaire: state.appState.activeQuestionnaire, | ||
}); | ||
const mapDispatchToProps = { | ||
loadQuestionnaireVersion, | ||
}; | ||
|
||
const QuestionnaireListComponentsContainer = connect(mapStateToProps)(Versions); | ||
const QuestionnaireListComponentsContainer = connect( | ||
mapStateToProps, | ||
mapDispatchToProps, | ||
)(Versions); | ||
|
||
export default QuestionnaireListComponentsContainer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you never set confirmLoad when trying to load another version (you can display the confirm component on every versions). Is this done on purpose ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit more tricky to do so I thought it was good enough for now. Especially since we want to move the version thing into a tab instead of a modal (if we make the ui more modern) so we won't need this anymore in the long run. since we'll be able to confirm it through a modal.
(I decided to go for the inline confirm for now because I didn't like to open a modal in a modal...)