Feature to undo a delete - "recycle bin" style

[KZzizzle]

Create a "folder" for deleted studies during the last 30 days so that they can be retrieved if the deletion was a mistake.

Event Horizon

Preview Give feedback

1. ✨ [Frontend] Trash bin osparc-simcore#6590
   a:frontend t:enhancement +2
   
2. Implement POST trash:empty
3. trashed_by
4. Delete project children when parent project is deleted
5. Trashing shared resources: which trash and who can untrash (trashed-by)
6. GC background task to fully delete trashed items
7. Investigate and address "orphaned" files that remain in S3 after a project is deleted (e.g., files from the file-picker or project outputs).
8. Reuse the existing "delete project" functionality to automatically delete projects after they expire (e.g. app-settings to 30 days).

Tasks

Preview Give feedback

1. Hide projects. Consider folders and sharing.
2. ✨ Trash projects osparc-simcore#6579
   a:database a:webserver +2
   
3. ✨ Trash folders osparc-simcore#6642
   a:api a:webserver +2
   
4. ✨ Trash workspaces osparc-simcore#6690
   a:api a:webserver +2
   

[KZzizzle]

can be done in "parallel" to the warning next to deleting a study #467

[elisabettai]

This has come up as well from Team Black on today's meeting (19.10). And will help also other users who might delete a study by mistake.
How difficult is to implement @pcrespov?

[pcrespov]

This has come up as well from Team Black on today's meeting (19.10). And will help also other users who might delete a study by mistake. How difficult is to implement @pcrespov?

@elisabettai We already did some trials with ideas. IMO it is feasible to have a first version within a sprint.

[pcrespov]

Goal for sprint Jelly Beans

• entrypoint to :delete (i.e. force-delete)
• entrypoint to :recycle
  • configurable expiration date
• list recycled studies
• entrypoint to :restore

[pcrespov]

• projects._delete_utils.py

async def mark_project_as_deleted(
    app: web.Application, project_uuid: ProjectID, user_id: UserID
):
    """
    ::raises ProjectInvalidRightsError
    ::raises ProjectNotFoundError
    """
    db: ProjectDBAPI = ProjectDBAPI.get_from_app_context(app)
    # TODO: tmp using invisible as a "deletion mark"
    # Even if any of the steps below fail, the project will remain invisible
    # TODO: see https://github.com/ITISFoundation/osparc-simcore/pull/2522
    await db.check_delete_project_permission(user_id, f"{project_uuid}")

    await db.check_project_has_only_one_product(project_uuid)

    # NOTE: if any of the steps below fail, it might results in a
    # services/projects/data that might be incosistent. The GC should
    # be able to detect that and resolve it.
    await db.set_hidden_flag(project_uuid, enabled=True)

[pcrespov]

MartinKippenberger Sprint

completed

• specifications: trash of sharable items (studies/folders/workspaces) that delete after pre-defined retention time
• studies can be trashed (PRs under review)
  • ✨ Trash projects osparc-simcore#6579
  • ✨ [Frontend] Trash bin osparc-simcore#6590

open

• folders can be trashed
• workspaces can be trashed
• improving deletion operation (connected to issues detected on pubic API)
• improve periodic background task that deletes trashed items after retention time

[mguidon]

• its about folders, workspaces and projects
• 3 entrypoints in the backend
• UX: We are following established ideas