-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Trash workspaces #6690
✨ Trash workspaces #6690
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6690 +/- ##
==========================================
+ Coverage 88.38% 89.38% +0.99%
==========================================
Files 1545 1361 -184
Lines 61619 55192 -6427
Branches 2164 1174 -990
==========================================
- Hits 54462 49333 -5129
+ Misses 6828 5683 -1145
+ Partials 329 176 -153
Continue to review full report in Codecov by Sentry.
|
8927e20
to
15b0d4f
Compare
a1a972b
to
3d3599f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking very good! Thanks!
packages/postgres-database/src/simcore_postgres_database/models/_common.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_exceptions_handlers.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_exceptions_handlers.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_trash_handlers.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/_common.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/workspaces.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot for the effort.
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/04/workspaces/test_workspaces.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the improvements (including the unit tests 💯)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
39385f2
to
737f7ae
Compare
Quality Gate passedIssues Measures |
What do these changes do?
web-api offers new operations to trash workspaces
Highlights
0.45.0 → 0.46.0
changes:POST /workspace/{workspace_id}:trash
POST /workspace/{workspace_id}:untrash
list_workpaces
addsfilters
queryWorkspaceGet
adds optionaltrashed_at
andtrashed_by
workspaces
tableNext steps
trashed_by
toprojects
andfolders
Related issue/s
How to test
Dev-ops
None