Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ introduce folder full search #6703

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 11, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 68.55346% with 50 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (f8f67c9) to head (df519e2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6703      +/-   ##
==========================================
+ Coverage   87.10%   88.56%   +1.45%     
==========================================
  Files        1569     1381     -188     
  Lines       63153    56619    -6534     
  Branches     2116     1131     -985     
==========================================
- Hits        55011    50142    -4869     
+ Misses       7817     6302    -1515     
+ Partials      325      175     -150     
Flag Coverage Δ
integrationtests 64.83% <34.02%> (+3.97%) ⬆️
unittests 86.28% <68.55%> (+0.57%) ⬆️
Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.01% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.32% <0.00%> (-0.46%) ⬇️
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 89.46% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.82% <ø> (+5.67%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.41% <ø> (ø)
payments 93.02% <ø> (ø)
resource_usage_tracker 90.75% <ø> (ø)
storage 89.76% <100.00%> (-0.01%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.72% <71.52%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f67c9...df519e2. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 11, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Nov 11, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 11, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 11, 2024 14:26
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets check offline. I have some questions i cannot deduce from the code. thx

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 12, 2024 09:48
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ refactor listing folders ♻️ introduce folder full search Nov 12, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ introduce folder full search ✨ introduce folder full search Nov 12, 2024
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit f7e6d5b into ITISFoundation:master Nov 12, 2024
84 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants