-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Mark new trash web-api as dev-features #6665
♻️ Mark new trash web-api as dev-features #6665
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks a lot
services/web/server/src/simcore_service_webserver/projects/_trash_handlers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6665 +/- ##
==========================================
- Coverage 87.97% 85.74% -2.23%
==========================================
Files 1568 613 -955
Lines 63362 31348 -32014
Branches 2089 265 -1824
==========================================
- Hits 55740 26878 -28862
+ Misses 7304 4409 -2895
+ Partials 318 61 -257
Continue to review full report in Codecov by Sentry.
|
What do these changes do?
WEBSERVER_DEV_FEATURES_ENABLED=1
. This way it is not released to production..codecov.yaml
to avoid false positives in CIRelated issue/s
How to test
Dev-ops checklist
None