-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAM Authentication #260
Merged
Merged
IAM Authentication #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentials to be added to a site
gregcorbett
requested review from
GRyall,
gregcorbett,
a user,
jrha and
tofu-rocketry
December 9, 2020 09:12
tofu-rocketry
requested review from
a team
and removed request for
jrha,
gregcorbett,
GRyall,
tofu-rocketry and
a user
December 9, 2020 09:35
norealroots
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
ghost
reviewed
Dec 9, 2020
Co-authored-by: ineilson <[email protected]>
Merged
gregcorbett
reviewed
Jan 28, 2022
gregcorbett
reviewed
Jan 28, 2022
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jan 28, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jan 28, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
This was referenced Feb 3, 2022
- shib will still be the main SSO usecase for 5.9.0, so I want to have that activiated by default.
gregcorbett
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎆
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
May 24, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jul 4, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jul 8, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jul 8, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Jul 8, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Aug 4, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Aug 9, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with the IRIS IAM service. All changes can be viewed on https://host-172-16-114-81.nubes.stfc.ac.uk/