Refer to X.509, not (x|X)509 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I've rebased this on top of the latest dev, but it still needs a second pass. |
gregcorbett
changed the title
gregcorbett
force-pushed
the
X.509
branch
2 times, most recently
from
a1d1cf0 to
f9799fe
Compare
|
I have now done a second, wider, pass. |
ghost
reviewed
Jul 11, 2022
|
I'm resisting tackling the codeclimate issues as part of this PR because it's like pulling a thread from a tapestry. |
|
The commit message on 3e6f7be doesn't at all match or explain what the commit is actually doing. |
gregcorbett
added a commit
to gregcorbett/gocdb
that referenced
this pull request
Aug 8, 2022
tofu-rocketry
approved these changes
Aug 8, 2022
- it's more technically correct, the best kind of correct - brings API credentials in line with other (GOCDB#294) around user credentials and account linking - this does "break" API access for existing credentials (until they next get edited), so we should release it: - after GOCDB#260 - maybe after GOCDB#294 - at the same as GOCDB#284, as users will have to edit API credentials anyway
- the code and ancient todo list reference X.509 so came up in my grep-ing.
- the slash is needed to prevent matching things like X+509, though the portal currently prevents such strings getting this far. Co-authored-by: ineilson <[email protected]>
|
Rebased to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more technically correct, (the best kind of correct), and brings the naming of the X.509 API credential in line with the X.509 user credential (#294).
so we should merge/release it:
After Refactor API Auth to support non X.509 identifiers #368or not, as this is ready for review.