Refer to X.509 for API credentials, not (x|X)509

- it's more technically correct, the best kind of correct
- brings API credentials in line with other (GOCDB#294) around
  user credentials and account linking
- this does "break" API access for existing credentials (until
  they next get edited), so we should release it:
  - after GOCDB#260
  - maybe after GOCDB#294
  - at the same as GOCDB#284, as users will have to edit API
    credentials anyway

config/gocdb_schema.xml

@@ -583,7 +583,7 @@
         <field>
             <fname>TYPE</fname>
             <length>255</length>
-            <regex>/^(X509|OIDC Subject)$/</regex>
+            <regex>/^(X.509|OIDC Subject)$/</regex>
         </field>
     </entity>
 </schema>

htdocs/PI/write/utils.php

@@ -63,7 +63,7 @@ function returnJsonWriteAPIResult ($httpResponseCode, $object) {
 function getAuthenticationInfo () {
   require_once __DIR__ . '/../../web_portal/components/Get_User_Principle.php';
   #Check if associated cert/token is set to define identifier type
-  if(isset($_SERVER['SSL_CLIENT_CERT'])){$identifierType = 'X509';}
+  if(isset($_SERVER['SSL_CLIENT_CERT'])){$identifierType = 'X.509';}
   if(isset($_SERVER['OIDC_access_token'])){$identifierType = 'OIDC Subject';}
 
   #This will return null if no cert is presented

htdocs/web_portal/controllers/site/add_api_auth.php

@@ -58,7 +58,7 @@ function draw(\User $user = null, \Site $site = null) {
 
     $params['site'] = $site;
     $params['authTypes'] = array();
-    $params['authTypes'][]='X509';
+    $params['authTypes'][]='X.509';
     $params['authTypes'][]='OIDC Subject';
 
     show_view("site/add_api_auth.php", $params);

htdocs/web_portal/controllers/site/edit_api_auth.php

@@ -60,7 +60,7 @@ function draw(\User $user = null, \APIAuthentication $authEnt = null, \Site $sit
     $params['site'] = $site;
     $params['authEnt'] = $authEnt;
     $params['authTypes'] = array();
-    $params['authTypes'][]='X509';
+    $params['authTypes'][]='X.509';
     $params['authTypes'][]='OIDC Subject';
 
     show_view("site/edit_api_auth.php", $params);

lib/Gocdb_Services/Site.php

@@ -1405,8 +1405,8 @@ public function addAPIAuthEntity(\Site $site, \User $user, $newValues) {
 
         //If the entity is of type X509, do a more thorough check than the validate service (as we know the type)
         //Note that we are allowing ':' as they can appear in robot DN's
-        if ($type == 'X509' && !preg_match("/^(\/[A-Za-z]+=[a-zA-Z0-9\/\-\_\s\.,'@:\/]+)*$/", $identifier)) {
-            throw new \Exception("Invalid x509 DN");
+        if ($type == 'X.509' && !preg_match("/^(\/[A-Za-z]+=[a-zA-Z0-9\/\-\_\s\.,'@:\/]+)*$/", $identifier)) {
+            throw new \Exception("Invalid X.509 DN");
         }
 
         //If the entity is of type OIDC subject, do a more thorough check again
@@ -1489,8 +1489,8 @@ public function editAPIAuthEntity(\APIAuthentication $authEntity, \User $user, $
 
         //If the entity is of type X509, do a more thorough check than the validate service (as we know the type)
         //Note that we are allowing ':' as they can appear in robot DN's
-        if ($type == 'X509' && !preg_match("/^(\/[A-Za-z]+=[a-zA-Z0-9\/\-\_\s\.,'@:\/]+)*$/", $identifier)) {
-            throw new \Exception("Invalid x509 DN");
+        if ($type == 'X.509' && !preg_match("/^(\/[A-Za-z]+=[a-zA-Z0-9\/\-\_\s\.,'@:\/]+)*$/", $identifier)) {
+            throw new \Exception("Invalid X.509 DN");
         }
 
         //If the entity is of type OIDC subject, do a more thorough check again