qmk_gui: Fix crash on flashing on Chinese language system #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would crash in to_str with 'utf-8' code can't decode byte ... That's because "VolumeName" the volume name would include Chinese characters. They should be decodeable by utf8, so not sure why it happens. But we don't actually use this in the output. Also note that the columns aren't orderd the way we ask them, but alphabetically. Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would crash in to_str with
'utf-8' code can't decode byte ...
That's because "VolumeName" the volume name would include Chinese characters. They should be decodeable by utf8, so not sure why it happens.
But we don't actually use this in the output.
Also note that the columns aren't orderd the way we ask them, but alphabetically.