Merge pull request #26 from FrameworkComputer/fix-decode-bug

qmk_gui: Fix crash on flashing on Chinese language system
FrameworkComputer · Oct 30, 2023 · 5c62a33 · 5c62a33
2 parents 3679a23 + 0512360
commit 5c62a33
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/uf2conv.py b/uf2conv.py
@@ -232,8 +232,10 @@ def to_str(b):
 def get_drives():
     drives = []
     if sys.platform == "win32":
+        # TODO: Could also check "VolumeName" == "RPI-RP2"
+        # But it should be okay because we check for the INFO file that no other drive would have
         r = subprocess.check_output(["wmic", "PATH", "Win32_LogicalDisk",
-                                     "get", "DeviceID,", "VolumeName,",
+                                     "get", "DeviceID,",
                                      "FileSystem,", "DriveType"])
         for line in to_str(r).split('\n'):
             words = re.split('\s+', line)