Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmk_gui: Fix crash on flashing on Chinese language system #26

Merged
merged 1 commit into from
Oct 30, 2023
Merged

qmk_gui: Fix crash on flashing on Chinese language system #26

merged 1 commit into from
Oct 30, 2023

Commits on Oct 27, 2023

  1. qmk_gui: Fix crash on flashing on Chinese language system 

    Would crash in to_str with
'utf-8' code can't decode byte ...

That's because "VolumeName" the volume name would include Chinese
characters. They should be decodeable by utf8, so not sure why it
happens.
But we don't actually use this in the output.

Also note that the columns aren't orderd the way we ask them, but
alphabetically.

Signed-off-by: Daniel Schaefer <[email protected]>
    @JohnAZoidberg
    JohnAZoidberg committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0512360 View commit details
    Browse the repository at this point in the history