This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
#290 fix truth/test data errors #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was one additional small issue discovered yesterday with this one in the test data that needs fixed so please hold off on merge:
|
|
@BobBooth - the "FOXHOLE, EMPLACEMENT" symbol has been fixed in test data/PR so this is ready to review now. |
|
@ACueva - Note updates to truth data. |
ACueva
reviewed
Mar 23, 2018
| @@ -137,13 +137,14 @@ OID,Annex,Affiliation,Full SIDC,SIDC By Parts,Hierarchy Code,Name,Geometry,Notes | |||
| 136,E,Friend,GFCPSLRW-------,G F C P SL RW -- -- -- -,2.X.2.4.2.2.5,TWO-WAY TRAFFIC,LINE, | |||
| 137,E,Friend,GFCPOLN--------,G F C P OL N- -- -- -- -,2.X.2.5.3.1,LIGHT LINE,LINE, | |||
| 138,E,Friend,GFCPOLP--------,G F C P OL P- -- -- -- -,2.X.2.5.3.2,PHASE LINE,LINE, | |||
There was a problem hiding this comment.
@ACueva - order of items shouldn't matter - but they will appear in this same order in the output feature class when run through the test generation process
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several additional errors were found in the truth data after viewing in Pro 2.2. This PR addresses these errors noted.
Related Issue
#290
Motivation and Context
How Has This Been Tested?
Test in Pro 2.2 with app6b dictionary renderer (Requires Pro 2.2 Beta/Daily to test) and latest app6b.stylx
Screenshots (if appropriate):
Types of changes
Checklist: