Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Create test data for APP6B with symbols below #290

Closed
2 tasks done
BobBooth opened this issue Jan 12, 2018 · 21 comments
Closed
2 tasks done

Create test data for APP6B with symbols below #290

BobBooth opened this issue Jan 12, 2018 · 21 comments
Labels
A-bug B-moderate E-verified S-Military Features V - Pro 2.1

Comments

@BobBooth
Copy link
Contributor

BobBooth commented Jan 12, 2018 •
edited by ACueva
Loading

Tasks to finish this issue:

After a review of the symbols not drawing in the runtime app using the app6b stylx, a number of cases were identified where the test data was incorrect.
This is where all the data is created from:
(https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/test-data/app6b/truth-data)
Some of these are errors in the SIDC string (typos) and some are features which exist to represent a top-level category in the standard that does not actually have a symbol associated (the more specific items in that category have specific symbols).

Brief summary of issue encountered:
Attributes from Comp Test Data Description From Standard Heirarchy Sym-ID Actual Standard Note
OID 316 Shape Point sic SFGPUUX-------- Label LANDING SUPPORT LANDING SUPPORT 1.X.3.1.2.6 SGUUL---***** UUX shuold be UUL This is an error in the test data
OID 467 Shape Point sic SFGPUHGL------- Label UNIT GENERAL LIAISON UNIT GENERAL LIAISON 1.X.3.1.7 SFG*GL----***** *GL This is an error in the test data
OID 469 Shape Point sic SFGPEW--------- Label WEAPONS       NO base/generic  EW item symbol in standard. EWM, EWA present. This is an error in the test data
OID 560 Shape Point sic SFGPEVEMV------ Label ARMOURED CARRIER WITH VOLCANO ARMOURED CARRIER WITH VOLCANO     No symbol item in standard, but table B-IV Warfighting Symbol ID Codes  p 127 has it as 1.X.3.2.2.3.4.3  with Function IDs of EV EM V- This is an error in the test data
OID 569 Shape Point sic SFGPEX--------- Label SPECIAL EQUIPMENT       NO base/generic  EX item symbol in standard. EXL, EXM, EXN, EXMC, EXML present. This is an error in the test data
OID 592 Shape Point sic SFGPIM----H---- Label MILITARY MATERIEL FACILITY   1.X.3.3.5   No symbol item in standard. This is an error in the test data
OID 611 Shape Point sic SFGPIRR---H---- Label SEA SURFACE INSTALLATION   1.X.3.4   No symbol item in standard. This is an error in the test data
OID 628 Shape Point sic SFSPCMMA------- Label MCM SUPPORT       No symbol item in standard. This is an error in the test data
OID 634 Shape Point sic SFSPG---------- Label NAVY GROUP   1.X.4.1.6   No symbol item in standard. This is an error in the test data
OID 635 Shape Point sic SFSPGT--------- Label NAVY TASK FORCE NAVY TASK FORCE 1.X.4.1.6.1 SSGF----***** Missing "F" - see column D for corrct string. Should be symbolized with TF in the This is an error in the test data
OID 643 Shape Point sic SFSPNRO-------- Label UNDERWAY REPLENISHMENT OIL UNDERWAY REPLENISHMENT, OIL 1.X.4.2.1.2 SSNOT---***** Should be "NOT" - see column D for corrct string. Should be symbolized with AO in circle. This is an error in the test data
OID 673 Shape Point sic SFSPZ---------- Label HAZARD   1.X.4.6   No symbol item in standard. This is an error in the test data
OID 669 Shape Point sic SFSPE---------- Label EMERGENCY   1.X.4.5   No symbol item in standard. This is an error in the test data
OID 664 Shape Point sic SFSPXFTR------- Label TRAWLER TRAWLER 1.X.4.3.2.2 SSXMTR--***** Error in string, XFTR should  be XMTR - symbol should be "TR" in the Fishing Vessel symbol. This is an error in the test data
OID 663 Shape Point sic SFSPXFDR------- Label DREDGE DREDGE 1.X.4.3.1.8 SSXMD---***** Error in string, XFDR should  be XMD - symbol should be "D" in the Merchant Vessel symbol. This is an error in the test data
OID 659 Shape Point sic SFSPXMH-------- Label HAZARDOUS MATERIALS HAZARDOUS MATERIALS TRANSPORT SHIP 1.X.4.3.1.7 SSXMHZ--***** Error in string, XMH should  be XMHZ - symbol should be "HZ" in the Merchant Vessel symbol. This is an error in the test data
OID 651 Shape Point sic SFSPX---------- Label NON MILITARY SEA SURFACE TRACK NONMILITARY 1.X.4.3   No symbol item in standard. This is an error in the test data
OID 699 Shape Point sic SFUPNB--------- Label BOTTOM RETURN/NOMBO BOTTOM RETURN/NOMBO 1.X.5.4.2   No symbol item in standard. This is an error in the test data
OID 706 Shape Point sic SFFPA---------- Label SOF UNIT AVIATION SOF AVIATION 1.X.6.1   No symbol item in standard. This is an error in the test data
OID 898 Shape Point sic GHOPVE--------- Label ASSASSINA TION/MURDER/ EXECUTION Assassination/Murder/Execution 2.X.3.1.3 GHO*VM---- *VE should be *VM This is an error in the test data
OID 930 Shape Point sic GHOPPG--------- Label FORAGING/SEARCHING Foraging/Searching 2.X.3.3.7 GHO*PF---- *PG should be *PF This is an error in the test data
OID 916 Shape Point sic GUOPLG--------- Label GRAY LIST LOCATION Grey List Location 2.X.3.2.2 GHO*LG---- GUO should be GHO This is an error in the test data
OID 955 Shape Point sic W-A-IC--------- Label CLEAR ICING Clear Icing 3.X.3.1 WAIC----***** No symbol item in standard. This is an error in the test data
OID 959 Shape Point sic W-A-IR--------- Label RIME ICING Rime Icing 3.X.3.2 WAIR----***** No symbol item in standard. This is an error in the test data
@BobBooth
Copy link
Contributor Author

@csmoore @topowright @dfoll @ACueva

@BobBooth BobBooth mentioned this issue Jan 12, 2018
Closed
csmoore added a commit that referenced this issue Jan 16, 2018
@csmoore
Address issues noted in #290
565d626
@csmoore
Copy link
Member

csmoore commented Jan 16, 2018

@BobBooth - thanks for finding these errors - started addressing in https://github.com/Esri/military-features-data/tree/csm/%23290-app6-truth-data-errors

@csmoore csmoore mentioned this issue Jan 18, 2018
Merged
csmoore added a commit that referenced this issue Jan 19, 2018
@csmoore
Merge pull request #292 from Esri/csm/#290-app6-truth-data-errors
61f9938 
Test/Truth data errors noted in #290
@csmoore
Copy link
Member

csmoore commented Jan 19, 2018

Errors with the test data should be fixed in #292 - should be ready for QA/QC

@BobBooth
Copy link
Contributor Author

I confirm that all of the above errors are fixed in #292, tested in ArcMap against https://github.com/Esri/military-features-data/blob/dev/military-symbology-styles/test-data/app6b/map-packages/Comprehensive-app6b.mpk

@BobBooth
Copy link
Contributor Author

This issue is ready to be closed.
@topowright

@topowright-zz
Copy link
Contributor

How do we verify that this is done.

@lfunkhouser lfunkhouser added this to the APR 2018 Sprint 2 milestone Feb 7, 2018
@csmoore
Copy link
Member

csmoore commented Feb 7, 2018

To verify this you can either follow these instructions from a similar issue - #291 (comment)

Or also test in Pro 2.2 daily

@lfunkhouser
Copy link
Member

@dfoll @ACueva @topowright Please read all comments in this issue, understand the issue, and identify the remaining work that needs to be completed.

@lfunkhouser lfunkhouser removed this from the APR 2018 Sprint 2 milestone Feb 20, 2018
@csmoore csmoore mentioned this issue Mar 21, 2018
Merged
6 tasks
ACueva pushed a commit that referenced this issue Mar 23, 2018
Merge pull request #314 from Esri/csm/#290-test-data-errors
b8b64d9 
#290 fix truth/test data errors
@ACueva
Copy link
Contributor

ACueva commented Mar 27, 2018 •
edited
Loading

Verified Landing Support - ArcGIS Pro 2.2 Build 11859

APP6B Standard:
2018-03-26_14-26-56
SGUUL---***** refers to:
2018-03-26_14-28-39
SGUUP---***** refers to:
2018-03-26_14-30-54
This was done this way per:
#85 (comment)

APP6B Standard:
2018-03-26_14-40-20
ArcGIS Pro 2.2 Build 11859
2018-03-26_14-43-36

APP6B Standard:
OID 560 Shape Point sic SFGPEVEMV------ Label ARMOURED CARRIER WITH VOLCANO
Confirmed no such SIDC and corresponding symbol exists in the APP6B Standard.
2018-03-27_11-03-57

@ACueva
Copy link
Contributor

ACueva commented Mar 27, 2018 •
edited
Loading

APP6B Standard:
OID 560 Shape Point sic SFGPEVEMV------ Label ARMOURED CARRIER WITH VOLCANO
Confirmed no such SIDC and corresponding symbol exists in the APP6B Standard. Was using an outdated Stylx file.
2018-03-27_11-03-57
2018-03-27_11-10-59
2525C
2018-03-27_11-30-51
Per the guidance received here: #85 (comment) I believe we should update the APP6B stylx to render similar to 2525C rather than render "unknown".
@BobBooth @csmoore @lfunkhouser @dfoll @topowright Thoughts?

@csmoore
Copy link
Member

csmoore commented Mar 27, 2018

@ACueva - there is probably some confusion with the branches - which is probably my fault since I didn't comment after #314 was merged - just ensure you are using the latest from "dev" versus the branch mentioned above: https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/test-data/app6b/pro-projects

That entry should look like this in the latest (merged after #314):

image

@ACueva
Copy link
Contributor

ACueva commented Mar 27, 2018

Thanks @csmoore I'll grab the latest branch and test.

@lfunkhouser lfunkhouser added this to the APR 2018 Sprint 9 milestone Mar 28, 2018
@ACueva
Copy link
Contributor

ACueva commented Mar 29, 2018

Merged test batch scripts. They now live in this repo.

@ACueva
Copy link
Contributor

ACueva commented Mar 29, 2018 •
edited
Loading

@csmoore The stylx file you referenced here: #290 (comment) brings up the following error message:
2018-03-29_15-11-40

Was running a definition query on the Full SIDC searching for "EVEM".
2018-03-29_15-16-01

The symbols still appear to render.
2018-03-29_15-14-27

I've gone ahead and logged an issue. #323

@ACueva
Copy link
Contributor

ACueva commented Mar 29, 2018

@csmoore I tried viewing the attribute table and now it shows up. Nothing changed other than I tried to view the attribute table a 2nd time.
2018-03-29_15-29-10

@ACueva
Copy link
Contributor

ACueva commented Mar 29, 2018 •
edited
Loading

APP6B Standard:
OID 469 Shape Point sic SFGPEW--------- Label WEAPONS

Annex Affiliation Full SIDC Hierarchy Code Name
D Friend SFGPEWM-------- 1.X.3.2.1.1 MISSILE LAUNCHERS
D Friend SFGPEWMA------- 1.X.3.2.1.1.1 AIR DEFENCE (AD) MISSILE LAUNCH
D Friend SFGPEWMAS------ 1.X.3.2.1.1.1.1 SHORT RANGE AD MISSILE LAUNCHERS
D Friend SFGPEWMAI------ 1.X.3.2.1.1.1.2 INTERMEDIATE RANGE AD MISSILE LAUNCH
D Friend SFGPEWMAL------ 1.X.3.2.1.1.1.3 LONG RANGE AD MISSILE LAUNCH
D Friend SFGPEWMAT------ 1.X.3.2.1.1.1.4 AD MISSILE LAUNCH THEATRE
D Friend SFGPEWMS------- 1.X.3.2.1.1.2 SURFACE-SURFACE (SS) MISSILE LAUNCHER
D Friend SFGPEWMSS------ 1.X.3.2.1.1.2.1 SHORT RANGE SS MISSILE LAUNCH
D Friend SFGPEWMSI------ 1.X.3.2.1.1.2.2 INTERMEDIATE RANGE SS MISSILE LAUNCH
D Friend SFGPEWMSL------ 1.X.3.2.1.1.2.3 LONG RANGE SS MISSILE LAUNCH
D Friend SFGPEWMT------- 1.X.3.2.1.1.3 MISSILE LAUNCHERS ANTI TANK (AT)
D Friend SFGPEWMTL------ 1.X.3.2.1.1.3.1 MISSILE LAUNCHERS AT LIGHT
D Friend SFGPEWMTM------ 1.X.3.2.1.1.3.2 MISSILE LAUNCHER AT MEDIUM
D Friend SFGPEWMTH------ 1.X.3.2.1.1.3.3 MISSILE LAUNCHER AT HEAVY
D Friend SFGPEWS-------- 1.X.3.2.1.2 SINGLE ROCKET LAUNCHER
D Friend SFGPEWSL------- 1.X.3.2.1.2.1 SINGLE ROCKET LAUNCHER LIGHT
D Friend SFGPEWSM------- 1.X.3.2.1.2.2 SINGLE ROCKET LAUNCHER MEDIUM
D Friend SFGPEWSH------- 1.X.3.2.1.2.3 SINGLE ROCKET LAUNCHER HEAVY
D Friend SFGPEWX-------- 1.X.3.2.1.3 MULTIPLE ROCKET LAUNCHER
D Friend SFGPEWXL------- 1.X.3.2.1.3.1 MULTIPLE ROCKET LAUNCHER LIGHT
D Friend SFGPEWXM------- 1.X.3.2.1.3.2 MULTIPLE ROCKET LAUNCHER MEDIUM
D Friend SFGPEWXH------- 1.X.3.2.1.3.3 MULTIPLE ROCKET LAUNCHER HEAVY
D Friend SFGPEWT-------- 1.X.3.2.1.4 ANTITANK ROCKET LAUNCHER
D Friend SFGPEWTL------- 1.X.3.2.1.4.1 ANTITANK ROCKET LAUNCHER LIGHT
D Friend SFGPEWTM------- 1.X.3.2.1.4.2 ANTITANK ROCKET LAUNCHER MEDIUM
D Friend SFGPEWTH------- 1.X.3.2.1.4.3 ANTITANK ROCKET LAUNCHER HEAVY
D Friend SFGPEWR-------- 1.X.3.2.1.5 RIFLE/AUTOMATIC WEAPON
D Friend SFGPEWRR------- 1.X.3.2.1.5.1 RIFLE
D Friend SFGPEWRL------- 1.X.3.2.1.5.2 LIGHT MACHINE GUN
D Friend SFGPEWRH------- 1.X.3.2.1.5.3 HEAVY MACHINE GUN
D Friend SFGPEWZ-------- 1.X.3.2.1.6 GRENADE LAUNCHER
D Friend SFGPEWZL------- 1.X.3.2.1.6.1 GRENADE LAUNCHER LIGHT
D Friend SFGPEWZM------- 1.X.3.2.1.6.2 GRENADE LAUNCHER MEDIUM
D Friend SFGPEWZH------- 1.X.3.2.1.6.3 GRENADE LAUNCHER HEAVY
D Friend SFGPEWO-------- 1.X.3.2.1.7 MORTAR
D Friend SFGPEWOL------- 1.X.3.2.1.7.1 MORTAR LIGHT
D Friend SFGPEWOM------- 1.X.3.2.1.7.2 MORTAR MEDIUM
D Friend SFGPEWOH------- 1.X.3.2.1.7.3 MORTAR HEAVY
D Friend SFGPEWH-------- 1.X.3.2.1.8 HOWITZER
D Friend SFGPEWHL------- 1.X.3.2.1.8.1 HOWITZER LIGHT
D Friend SFGPEWHLS------ 1.X.3.2.1.8.1.1 HOWITZER LIGHT SELF-PROPELLED
D Friend SFGPEWHM------- 1.X.3.2.1.8.2 HOWITZER MEDIUM
D Friend SFGPEWHMS------ 1.X.3.2.1.8.2.1 HOWITZER MEDIUM SELF-PROPELLED
D Friend SFGPEWHH------- 1.X.3.2.1.8.3 HOWITZER HEAVY
D Friend SFGPEWHHS------ 1.X.3.2.1.8.3.1 HOWITZER HEAVY SELF-PROPELLED
D Friend SFGPEWG-------- 1.X.3.2.1.9 ANTITANK GUN
D Friend SFGPEWGR------- 1.X.3.2.1.9.1 ANTITANK GUN RECOILLESS
D Friend SFGPEWGL------- 1.X.3.2.1.9.2 ANTITANK GUN LIGHT
D Friend SFGPEWGM------- 1.X.3.2.1.9.3 ANTITANK GUN MEDIUM
D Friend SFGPEWGH------- 1.X.3.2.1.9.4 ANTITANK GUN HEAVY
D Friend SFGPEWD-------- 1.X.3.2.1.10 DIRECT FIRE GUN
D Friend SFGPEWDL------- 1.X.3.2.1.10.1 DIRECT FIRE GUN LIGHT
D Friend SFGPEWDLS------ 1.X.3.2.1.10.1.1 DIRECT FIRE GUN LIGHT SELF-PROPELLED
D Friend SFGPEWDM------- 1.X.3.2.1.10.2 DIRECT FIRE GUN MEDIUM
D Friend SFGPEWDMS------ 1.X.3.2.1.10.2.1 DIRECT FIRE GUN MEDIUM SELF-PROPELLED
D Friend SFGPEWDH------- 1.X.3.2.1.10.3 DIRECT FIRE GUN HEAVY
D Friend SFGPEWDHS------ 1.X.3.2.1.10.3.1 DIRECT FIRE GUN HEAVY SELF-PROPELLED
D Friend SFGPEWA-------- 1.X.3.2.1.11 AIR DEFENCE GUN
D Friend SFGPEWAL------- 1.X.3.2.1.11.1 AIR DEFENCE GUN LIGHT
D Friend SFGPEWAM------- 1.X.3.2.1.11.2 AIR DEFENCE GUN MEDIUM
D Friend SFGPEWAH------- 1.X.3.2.1.11.3 AIR DEFENCE GUN HEAVY

2018-03-29_16-04-24
2018-03-29_16-04-14
2018-03-29_16-04-34
2018-03-29_16-04-44
2018-03-29_16-05-27

APP6B Standard:
2018-03-29_16-14-45

@ACueva
Copy link
Contributor

ACueva commented Mar 30, 2018

We have a way forward on displaying the symbols we have tested. I am working on documenting this process and setting up how the results will be displayed.

@ACueva
Copy link
Contributor

ACueva commented Mar 30, 2018

I've increased the estimate as the scope of this issue has increased due to the addition of the results table and associated documentation.

@lfunkhouser
Copy link
Member

lfunkhouser commented Apr 2, 2018 •
edited
Loading

@ACueva please provide more information on the way forward for displaying the symbols.

@BobBooth BobBooth self-assigned this Apr 2, 2018
@topowright-zz topowright-zz changed the title Fix test data for APP6B Create test data for APP6B with symbols below Apr 2, 2018
@BobBooth BobBooth removed their assignment Apr 2, 2018
@ACueva ACueva mentioned this issue Apr 2, 2018
Merged
4 tasks
@ACueva
Copy link
Contributor

ACueva commented Apr 2, 2018

#325 Addresses the supporting files needed for our verification scripts.

Wiki has been updated here:
https://github.com/Esri/military-features-data/wiki/Issue-verification-matrix

IMO this issue can be closed once PR #325 has been reviewed and merged.

@ACueva ACueva removed their assignment Apr 3, 2018
topowright-zz pushed a commit that referenced this issue Apr 4, 2018
Merge pull request #325 from Esri/ac/#290
66f99d3 
APP6B Verification scripts updates merging this based on the verification from Chris M
@lfunkhouser lfunkhouser removed this from the APR 2018 Sprint 10 milestone Apr 13, 2018
@lfunkhouser
Copy link
Member

verified. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-bug B-moderate E-verified S-Military Features V - Pro 2.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@csmoore @ACueva @lfunkhouser @BobBooth @topowright-zz