Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v3 1950 compsets #6053

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Add support for v3 1950 compsets #6053

merged 3 commits into from
Feb 22, 2024

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Nov 6, 2023

This PR adds supporting files for v3 1950 compsets.

  • Volcanic SO2 emission is 1950 eruption plus the historical average
  • Other surface and upper level forcings set to cycle over year 1950 of the historical forcings

Fixes #6016.

[BFB] Non-1950 tests are not affected.


Notes:

  • The 1950 ne30pg2 surfdata with TOP file currently contains place holder for variables related to TOP scheme.
  • 1950 for ne120 still needs IC file for atm.
  • With this PR, F1950 can run with L80 v3 config. B-case 1950 is expected to also be able to run.

Copy link

github-actions bot commented Nov 6, 2023

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6053/
on branch gh-pages at 2024-02-18 05:07 UTC

@wlin7
Copy link
Contributor Author

wlin7 commented Nov 6, 2023

@hwangacme , you created forcings for use by v2 1950 compsets. The forcings seem to be a subset of historical forcings (1950-1960). Should we still use the same for v3? The v3 1850 compsets set to cycle over a single year of 1850 for forcings. I am using the same format for 1950 for now.

@keziming , regarding the volcanic SO2 emission, I am using the average of 1850-2014 as you created for piControl. The time variables are modified to align with 1950 compsets (to allow a single cycling year for all elevated forcings). Do you feel there is a need to use an average around 1950 instead? In V2, it was set to cycle over a single year of 1950 from a specified 1950-1960 file created by Hailong.

@hwangacme
Copy link
Contributor

@hwangacme , you created forcings for use by v2 1950 compsets. The forcings seem to be a subset of historical forcings (1950-1960). Should we still use the same for v3? The v3 1850 compsets set to cycle over a single year of 1850 for forcings. I am using the same format for 1950 for now.

@keziming , regarding the volcanic SO2 emission, I am using the average of 1850-2014 as you created for piControl. The time variables are modified to align with 1950 compsets (to allow a single cycling year for all elevated forcings). Do you feel there is a need to use an average around 1950 instead? In V2, it was set to cycle over a single year of 1950 from a specified 1950-1960 file created by Hailong.

@wlin7 I didn't make the decision of which forcing files to be used for the 1950 compset, but I think it makes sense to take the single year 1950 forcing from the historical 1850-2014 forcing files.

@keziming
Copy link
Contributor

@hwangacme , you created forcings for use by v2 1950 compsets. The forcings seem to be a subset of historical forcings (1950-1960). Should we still use the same for v3? The v3 1850 compsets set to cycle over a single year of 1850 for forcings. I am using the same format for 1950 for now.
@keziming , regarding the volcanic SO2 emission, I am using the average of 1850-2014 as you created for piControl. The time variables are modified to align with 1950 compsets (to allow a single cycling year for all elevated forcings). Do you feel there is a need to use an average around 1950 instead? In V2, it was set to cycle over a single year of 1950 from a specified 1950-1960 file created by Hailong.

@wlin7 I didn't make the decision of which forcing files to be used for the 1950 compset, but I think it makes sense to take the single year 1950 forcing from the historical 1850-2014 forcing files.

@wlin7 there was a volcanic eruption during 1950s (1956 I guess). In general, the volcanic activities in 1950s are similar to 1850-2014 average, not too strong or weak. Do you mean you plan to create a new SO2 external emission file? If so, it would be OK to use piControl VOLC sector plus all other SO2 external emission sectors in 1950s. If I remember correctly, there is no eruption in year 1950 alone.

Copy link
Contributor

@keziming keziming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For file cmip6_1850_2014_avg_so2_elev_strat_1950_c20230310.nc, I need a clarification of its sectors. All sectors but volcanic in this file should be 1950s average, right? Thanks.

<ext_frc_cycle_yr >1950</ext_frc_cycle_yr>
<no2_ext_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_NO2_aircraft_vertical_1750-2015_1.9x2.5_c20170608.nc </no2_ext_file>
<!-- Use 1850-2014 averaged volcanic SO2 emission for 1950 -->
<so2_ext_file >atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/cmip6_1850_2014_avg_so2_elev_strat_1950_c20230310.nc </so2_ext_file>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlin7 It may need some clarifications. SO2 external forcing contains several sectors of emission, volcanic emission is only a part of it. In this file, ideally, it should be 1950s emissions from other sectors in addition to 1850-2014 averaged volcanic emission.

Copy link
Contributor Author

@wlin7 wlin7 Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for carefully reviewing the settings, @keziming . In v2, the SO2 external forcing for 1950 compset appears to be cycling over a single year 1950 instead of an average. (file atm/cam/chem/trop_mozart_aero/emis/DECK_ne120/cmip6_mam4_so2_elev_1950-1960_c180203.nc). We can also use single year 1950 or an average around 1950 for non-volcanic SO2 emissions. Can you please help to update those other sectors? We should have some discussion on 1950 forcings in general in next atm group meeting.

Copy link
Contributor

@tangq tangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@darincomeau
Copy link
Member

Thanks @wlin7 for putting this together - greatly appreciated!

Passes SMS.ne30pg2_EC30to60E2r2.WCYCL1950.anvil_intel and SMS.ne30pg2_ECwISC30to60E2r1.CRYO1950.anvil_intel

I tried a tri-grid configuration, but SMS.ne30pg2_r05_ECwISC30to60E3r2.WCYCL1950.anvil_intel failed on setup with

ERROR : CLM build-namelist::ELMBuildNamelist::add_default() : No default value found for fsurdat.

Is tri-grid meant to be supported? The same grid but with WCYCL1850 works.

So far I've only run the short SMS tests, but if you'd like a longer test where we can look at output, happy to do that.

@darincomeau
Copy link
Member

Also, here's the issue this is fixing: #6016

@wlin7
Copy link
Contributor Author

wlin7 commented Nov 13, 2023

@darincomeau , thanks for testing and nice to see the bigrid test passes. The data for tri-grid r05, simyr1950 has never been established. I just added it to the list of files needing to be updated/created.

@darincomeau
Copy link
Member

Ok great, good to know. Thanks again @wlin7 !

@rljacob
Copy link
Member

rljacob commented Dec 5, 2023

@wlin7 how is the creation of those files going? This PR needs to be done be the v3.0.0 tag is made.

@rljacob
Copy link
Member

rljacob commented Dec 7, 2023

Waiting on @keziming to provide forcing files.

@rljacob
Copy link
Member

rljacob commented Jan 4, 2024

@keziming are the forcing files ready?

@keziming
Copy link
Contributor

keziming commented Jan 4, 2024

@keziming are the forcing files ready?

I plan to finished it before this weekend. Sorry for the delay.
update:
I created a new file [so2_elev_strat_1950.nc] under /lcrc/group/e3sm/data/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30
What I did:
I grabed 1949-1951 period SO2 external emission from [cmip6_mam4_so2_elev_1850-2014_c180205.nc] (V2 SO2 historical emission file)
Then I added historical averaged eruptive volcano emission (used for piControl simulation) and modified the vertical layer coordinates.
if our simulation use "cycle 1950", it should serve the purpose.
please give a test run with the 1950 compset.

@rljacob rljacob added this to the v3.0.0-rc milestone Jan 8, 2024
@rljacob
Copy link
Member

rljacob commented Jan 19, 2024

@wlin7 can you check that this works with the new files @keziming made?

Copy link
Contributor

@hwangacme hwangacme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the tracer_cnst_cycle_yr is cycling the year 1955 input. I cannot recall why it was set this way.

@rljacob
Copy link
Member

rljacob commented Jan 29, 2024

@wlin7 please confirm this is ready.

@rljacob
Copy link
Member

rljacob commented Feb 1, 2024

Notes: @wlin7 will test new files.

wlin7 added a commit that referenced this pull request Feb 22, 2024
Add support for v3 1950 compsets

This PR adds supporting files for v3 1950 compsets.

Volcanic SO2 emission is 1950 eruption plus the historical average
Other surface and upper level forcings set to cycle over year 1950 of the historical forcings
Fixes #6016.

[BFB] Non-1950 tests are not affected.

* origin/wlin/atm/v3_1950_compset:
  Update elevated so2 forcing for lnd config for 1950 compsets
  Correct 1950 DMS file
  Add support for v3 1950 compsets
@wlin7
Copy link
Contributor Author

wlin7 commented Feb 22, 2024

@keziming , this compset is now using the updated SO2 emission for 1950 you produced (so2_elev_strat_1950.nc). Thanks.

Merged to next.

@wlin7 wlin7 merged commit 9dcf200 into master Feb 22, 2024
10 checks passed
@wlin7 wlin7 deleted the wlin/atm/v3_1950_compset branch February 22, 2024 20:03
@wlin7
Copy link
Contributor Author

wlin7 commented Feb 22, 2024

Merged to master.

@keziming
Copy link
Contributor

@wlin7 great

@rljacob rljacob modified the milestones: v3.0.0-rc1, v3.0.0-rc2, v3.0.0 Feb 29, 2024
@zzzeamon
Copy link

@keziming , this compset is now using the updated SO2 emission for 1950 you produced (so2_elev_strat_1950.nc). Thanks.

Merged to next.

could you please upload so2_elev_strat_1950.nc to "https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/" ?

@keziming
Copy link
Contributor

@keziming , this compset is now using the updated SO2 emission for 1950 you produced (so2_elev_strat_1950.nc). Thanks.
Merged to next.

could you please upload so2_elev_strat_1950.nc to "https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/" ?

just copied file to https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/

@zzzeamon
Copy link

@keziming , this compset is now using the updated SO2 emission for 1950 you produced (so2_elev_strat_1950.nc). Thanks.
Merged to next.

could you please upload so2_elev_strat_1950.nc to "https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/" ?

just copied file to https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/cam/chem/trop_mozart_aero/emis/DECK_ne30/

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCYCL1950 and CRYO1950 compsets are broken
7 participants