Add prescribed tidal effect on ice shelf basal melting #76
Conversation
Keep code from m_adjust_ps=false
This update synchronizes the data structure change between sbetr and elm. It fixed with failure of tests SMS_D.f19_g16.I1850ELM. The fix is BFB.
There was a problem hiding this comment.
@irenavankova, this looks great to me! I'd like to run a sort (say 5 year) IcoswISC30E3r5 test with it before we move over to E3SM just to make sure there are no surprises.
The only other thing I saw was the comment here about maybe naming the files slightly differently and at least including a date stamp so we can potentially add future versions if we need to without losing or modifying the old ones.
| @@ -295,6 +303,8 @@ def buildnml(case, caseroot, compname): | |||
| ic_prefix = 'mpaso.IcoswISC30E3r5.rstFromG-chrysalis' | |||
| if ocn_ismf == 'data': | |||
| data_ismf_file = 'prescribed_ismf_adusumilli2020.IcoswISC30E3r5.20231120.nc' | |||
| if ocn_tidal_mixing == 'true': | |||
| u_tidal_rms_file = 'IcoswISC30E3r5_velocityTidalRMS_CATS2008.nc' | |||
There was a problem hiding this comment.
Just a note that I have Compass generating files with a slightly different naming convention:
velocityTidalRMS_CATS2008.IcoswISC30E3r5.20231120.nc
This is how I ordered things for the data ice-shelf melt and data iceberg freshwater fluxes, and it's a good idea to have a date stamp.
It think it might be good rename the existing files with this convention or at least to add a date stamp to each of them.
|
@irenavankova, is it okay if I push a commit to add |
|
I wanted to do bit-for-bit testing on this with WCYCL1850 and Icos, and with CRYO1850 with both the Icos and SORRM meshes. But there are several missing pieces to make that possible:
In addition to the request for |
|
Yes, of course. |
|
@irenavankova, as we discussed, let's get the missing frazil contribution to melt rates sorted out. We can decide if that happens before this goes in but it would need to happen before we decide whether to turn this feature on by default in CRYO compsets. |
This data set is an Antarctic melt-rate climatology covering the years 1992-2017. The new datasets is an improvement because: * it is more accurate than the previous Adusumilli et al. (2020) * it includes rerouting of fluxes that are not under ice shelves in the MPAS-Ocean mesh * the fluxes are carefully renormalized so that the total flux is identical to the original Paolo et al. dataset * fixes the sign of the heat flux
Nightly e3sm_prod_bench needs to run with production mesh.
|
@xylar, do we need to wait for the new sorrm mesh to let this in? that is still in discussions |
|
@jonbob, it sounded at some point like you had concerns about the new |
No, I think this can move to E3SM as soon as you and @jonbob decide whether the |
This update synchronizes the data structure change between sbetr and elm. It fixes the failure of tests SMS_D.f19_g16.I1850ELM. [BFB]. Fixes E3SM-Project#5832
|
@jonbob, is it ok to move this one to E3SM Project, now that I have removed the redundant short names? |
|
@irenavankova -- of course. We can get more eyes on it there if needed |
…ll ISMF and add TMIX when PISMF
irenavankova
force-pushed
the
ocn/add-tidal-mixing-to-ice-shelf-melt
branch
from
7c8311e to
4d22b59
Compare
|
I rebased to master and moved to E3SM Project |
An implementation of prescribed tidal effect on ice shelf basal melting following (Jourdain et al., 2019):
https://doi.org/10.1016/j.ocemod.2018.11.001
The tidal flow speeds used to produce a forcing data file (_velocityTidalRMS_CATS2008.nc) are calculated from the CATS 2008 (an update of Padman et al., 2002)
When the file is available and compset TMIX on, the Jourdain formula is used. The main change is that what used to be a constant config_land_ice_flux_rms_tidal_velocity is now a spatially variable (horizontal) field.