-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ID-1352] Update TNU version in Dockerfile #495
Conversation
Use latest version 0.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samanehsan the change looks good, but you need to bump up the version of all of the docker containers appropriately, see CONTRIBUTING.md
Here is a previous PR updating TNU that should be a good baseline #449 |
@LizBaldo, I made the changes you requested |
Thanks! Let's see if the tests are passing, I can move this PR along if needed |
@LizBaldo there are two tests failing but I don't quite understand the errors. Could you take a look? |
Yep, I am on it and will move the PR along :) |
@samanehsan and @tlangs how critical is the release of TNU 14? As you can see, this PR is getting very unwieldy and I think it is about time that I refactor the base image first, and this whole process frankly. But that might take me a sprint or so, hence delaying the release of TNU further |
@LizBaldo it's not super urgent so it can wait a sprint or two. The release includes these two changes:
|
@samanehsan FYI things are looking almost ready to ship, finally :) If you don't mind giving the sister PR in Leonardo a review that would be awesome, thanks! DataBiosphere/leonardo#4784 |
Use latest version 0.14: https://pypi.org/project/terra-notebook-utils/0.14.0/ which has the following changes