Skip to content

Commit

Permalink
Revert "[ID-1352] Update TNU version in Dockerfile" (#496)
Browse files Browse the repository at this point in the history
* Revert "[ID-1352] Update TNU version in Dockerfile (#495)"

This reverts commit 33c9adc.

* keep the gha workflow updates
  • Loading branch information
LizBaldo authored Oct 31, 2024
1 parent 33c9adc commit 123bc45
Show file tree
Hide file tree
Showing 18 changed files with 36 additions and 95 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

We do our work on a feature branch based on master. When you open a pull request, add the JIRA issue number to the PR title. This will make a reference from JIRA to the GitHub issue. Briefly describe your changes in the description section.

This is also a good opportunity to verify that all the appropriate image versions were bumped. It is important to keep in mind which images extend from where ([Image Dependecies](https://github.com/DataBiosphere/terra-docker#image-dependencies)). Make sure to bump the version of the image you are changing in `config/conf.json` and update its reference in all images that extend from it.
This is also a good opportunity to verify that all the appropriate image versions were bumped. It is important to keep in mind which images extend from where ([Image Dependecies](https://github.com/DataBiosphere/terra-docker#image-dependencies)). Make sure to bump the version of the image you are changing and update its reference in all images that extend from it.

You can also run `amm ./updateVersions.sc <image name> <release note>` to upgrade derived images. If you're updating `terra-jupyter-aou` image, please make a pull request similar to [this PR](https://github.com/DataBiosphere/leonardo/pull/1612) (less updating `terra_jupyter_aou_old`).

Expand Down
26 changes: 13 additions & 13 deletions config/conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"tidyverse"
]
},
"version" : "2.2.6",
"version" : "2.2.5",
"automated_flags" : {
"generate_docs" : true,
"include_in_ui" : true,
Expand All @@ -47,7 +47,7 @@
"hail"
]
},
"version" : "1.1.13",
"version" : "1.1.12",
"automated_flags" : {
"generate_docs" : true,
"include_in_ui" : true,
Expand All @@ -68,7 +68,7 @@
"scikit-learn"
]
},
"version" : "1.1.6",
"version" : "1.1.5",
"automated_flags" : {
"generate_docs" : true,
"include_in_ui" : true,
Expand All @@ -84,9 +84,9 @@
"python"
],
"packages" : {

},
"version" : "1.1.4",
"version" : "1.1.3",
"automated_flags" : {
"generate_docs" : true,
"include_in_ui" : false,
Expand All @@ -102,9 +102,9 @@
"r"
],
"packages" : {

},
"version" : "2.2.6",
"version" : "2.2.5",
"automated_flags" : {
"include_in_ui" : false,
"generate_docs" : true,
Expand All @@ -122,9 +122,9 @@
"r"
],
"packages" : {

},
"version" : "2.3.8",
"version" : "2.3.7",
"automated_flags" : {
"include_in_ui" : true,
"generate_docs" : true,
Expand All @@ -141,9 +141,9 @@
"r"
],
"packages" : {

},
"version" : "2.2.14",
"version" : "2.2.13",
"automated_flags" : {
"include_in_ui" : false,
"generate_docs" : false,
Expand All @@ -159,7 +159,7 @@
"r"
],
"packages" : {

},
"version" : "0.1.1",
"automated_flags" : {
Expand All @@ -176,7 +176,7 @@
"tools" : [
],
"packages" : {

},
"version" : "0.0.1",
"automated_flags" : {
Expand Down
8 changes: 0 additions & 8 deletions terra-jupyter-aou/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
## 2.2.14 - 2024-09-04
- Update `terra-jupyter-gatk` to `2.3.8`
- Update `terra-jupyter-python` to `1.1.6`
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.14`

## 2.2.13 - 2024-08-12
- Update `hail` to `0.2.130.post1`
- See https://github.com/hail-is/hail/releases/tag/0.2.130.post1 for details
Expand Down
10 changes: 5 additions & 5 deletions terra-jupyter-aou/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-gatk:2.3.8
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-gatk:2.3.7

USER root

Expand Down Expand Up @@ -195,10 +195,10 @@ RUN apt-get update && \
&& rm -rf /var/lib/apt/lists/*
RUN pip install --upgrade pip && pip install --verbose h5py

# QIIME 2 2024.5 Amplicon Distribution
RUN curl -fsSL -o qiime2-2024.5.yml https://data.qiime2.org/distro/amplicon/qiime2-amplicon-2024.5-py39-linux-conda.yml && \
conda env create -n qiime2-2024.5 --file qiime2-2024.5.yml && \
rm qiime2-2024.5.yml
# RW-8725 INSTALL QIMEE2
RUN curl -fsSL -o qiime2-2022.8.yml https://data.qiime2.org/distro/core/qiime2-2022.8-py38-linux-conda.yml && \
conda env create -n qiime2-2022.8 --file qiime2-2022.8.yml && \
rm qiime2-2022.8.yml

# Install jellyfish
RUN mkdir -p /tmp/jellyfish && \
Expand Down
5 changes: 0 additions & 5 deletions terra-jupyter-base/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
## 1.1.4 - 2024-09-04
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:1.1.4`

## 1.1.3 - 2023-10-03
- Downgrade notebook to `6.5.4` and jupyterlab-server to `2.23.0`

Expand Down
5 changes: 1 addition & 4 deletions terra-jupyter-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,10 @@ RUN pip3 -V \
# for jupyter_delocalize.py and jupyter_notebook_config.py
# DO NOT CHANGE OR UNPIN NOTEBOOK OR JUPYTERLAB-SERVER! When trying with 6.5.5 and 2.24.0 notebook commands could not find the notebook config file
&& pip3 install notebook==6.5.4 \
&& pip3 install jupyter-server==1.24.0 \
&& pip3 install jupyterlab-server==2.23.0 \
# See: https://stackoverflow.com/questions/77549493/modulenotfounderror-no-module-named-jupyter-server-contents/77549554#77549554
&& pip3 install traitlets==5.9.0 \
&& pip3 install requests \
&& pip3 install firecloud \
&& pip3 install terra-notebook-utils==0.14.0 \
&& pip3 install terra-notebook-utils==0.13.0 \
&& pip3 install crcmod \
# For gcloud alpha storage support.
&& pip3 install google-crc32c --target /usr/lib/google-cloud-sdk/lib/third_party \
Expand Down
8 changes: 0 additions & 8 deletions terra-jupyter-bioconductor/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
## 2.2.6 - 2024-09-04

- Update `terra-jupyter-r` to `2.2.6`
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-bioconductor:2.2.6`

## 2.2.5 - 2024-05-15T15:36:28.576892790Z

- Update `terra-jupyter-r` to `2.2.5`
Expand Down
2 changes: 1 addition & 1 deletion terra-jupyter-bioconductor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.2.6
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.2.5
8 changes: 0 additions & 8 deletions terra-jupyter-gatk/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
## 2.3.8 - 2024-09-04
- Update `terra-jupyter-python` to `1.1.6`
- Update `terra-jupyter-r` to `2.2.6`
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-gatk:2.3.8`

## 2.3.7 - 2024-05-15T15:36:28.602743427Z

- Update `terra-jupyter-r` to `2.2.5`
Expand Down
6 changes: 3 additions & 3 deletions terra-jupyter-gatk/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-python:1.1.6 AS python
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-python:1.1.5 AS python

FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.2.6
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.2.5

USER root

Expand All @@ -27,7 +27,7 @@ ENV PIP_USER=false
# uninstalling packages: https://github.com/conda/conda/issues/10357
COPY --from=python /etc/terra-docker/requirements.txt /etc/terra-docker/base_requirements.txt

RUN pip install -r /etc/terra-docker/base_requirements.txt
RUN pip install --upgrade -r /etc/terra-docker/base_requirements.txt

# Install GATK
ENV GATK_VERSION 4.3.0.0
Expand Down
7 changes: 0 additions & 7 deletions terra-jupyter-hail/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
## 1.1.13 - 2024-09-04
- Update `terra-jupyter-python` to `1.1.6`
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-hail:1.1.13`

## 1.1.12 - 2024-08-12
- Update `hail` to `0.2.130.post1`
- See https://github.com/hail-is/hail/releases/tag/0.2.130.post1 for details
Expand Down
2 changes: 1 addition & 1 deletion terra-jupyter-hail/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-python:1.1.6
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-python:1.1.5

USER root

Expand Down
6 changes: 0 additions & 6 deletions terra-jupyter-python/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
## 1.1.6 - 2024-09-04
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-python:1.1.6`

## 1.1.5 - 2023-11-28
- Pin bleach to `6.0.0`

Expand Down
2 changes: 1 addition & 1 deletion terra-jupyter-python/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:1.1.4
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:1.1.3

USER root
# This makes it so pip runs as root, not the user.
Expand Down
6 changes: 0 additions & 6 deletions terra-jupyter-python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,3 @@ scikit-learn-intelex
xgboost
#older version of nbconvert fail to convert notebooks to html
nbconvert>=7.7.3
# See: https://github.com/GoogleCloudPlatform/generative-ai/issues/849
shapely==1.8.5.post1
pygeos==0.12.0
geopandas==0.10.2
# See: https://github.com/pypa/setuptools/issues/4483
setuptools<71.0.0
12 changes: 6 additions & 6 deletions terra-jupyter-python/tests/smoke_test.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@
"metadata": {},
"outputs": [],
"source": [
"output = !pip3 show emoji\n",
"output = !pip3 show pendulum\n",
"print(output) # Should show not yet installed.\n",
"assert(0 == output.count('Name: emoji'))"
"assert(0 == output.count('Name: pendulum'))"
]
},
{
Expand All @@ -96,7 +96,7 @@
"metadata": {},
"outputs": [],
"source": [
"%pip install emoji --user --ignore-installed"
"%pip install pendulum==2.1.2 --user --ignore-installed"
]
},
{
Expand All @@ -105,9 +105,9 @@
"metadata": {},
"outputs": [],
"source": [
"output = !pip3 show emoji\n",
"output = !pip3 show pendulum\n",
"print(output) # Should show that it is now installed!\n",
"assert(1 == output.count('Name: emoji'))"
"assert(1 == output.count('Name: pendulum'))"
]
},
{
Expand Down Expand Up @@ -248,7 +248,7 @@
"source": [
"import numpy as np\n",
"import pandas as pd\n",
"from ydata_profiling import ProfileReport\n",
"from pandas_profiling import ProfileReport\n",
"\n",
"df = pd.DataFrame(\n",
" np.random.rand(100, 5),\n",
Expand Down
6 changes: 0 additions & 6 deletions terra-jupyter-r/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
## 2.2.6 - 2024-09-04
- Update `terra-jupyter-base` to `1.1.4`
- Update terra-notebook-utils to `0.14.0`

Image URL: `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-r:2.2.6`

## 2.2.5 - 2024-05-15T15:36:28.555690376Z

- Update for R 4.4.0 and Bioc 3.19
Expand Down
10 changes: 4 additions & 6 deletions terra-jupyter-r/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:1.1.4
FROM us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:1.1.3

USER root

COPY scripts $JUPYTER_HOME/scripts

# Add env vars to identify binary package installation
ENV TERRA_R_PLATFORM="terra-jupyter-r-2.2.6"
ENV TERRA_R_PLATFORM="terra-jupyter-r-2.2.5"
ENV TERRA_R_PLATFORM_BINARY_VERSION=3.19

# Install protobuf 3.20.3. Note this version comes from base deep learning image. Use `conda list` to see what's installed
Expand Down Expand Up @@ -117,10 +117,8 @@ RUN apt-get update \
# Add libsbml CFLAGS
ENV LIBSBML_CFLAGS="-I/usr/include"
ENV LIBSBML_LIBS="-lsbml"
ENV XML_CONFIG="/usr/bin/xml2-config"
RUN echo 'export LIBSBML_CFLAGS="-I/usr/include"' >> /etc/profile \
&& echo 'export LIBSBML_LIBS="-lsbml"' >> /etc/profile \
&& echo 'export XML_CONFIG="/usr/bin/xml2-config"' >> /etc/profile
&& echo 'export LIBSBML_LIBS="-lsbml"' >> /etc/profile

## set pip3 to run as root, not as jupyter user
ENV PIP_USER=false
Expand Down Expand Up @@ -189,4 +187,4 @@ ENV PIP_USER=true
RUN R -e 'IRkernel::installspec(user=FALSE)' \
&& chown -R $USER:users /usr/local/lib/R/site-library /home/jupyter

USER $USER
USER $USER

0 comments on commit 123bc45

Please sign in to comment.