Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-5056] Update TNU version #4784

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[IA-5056] Update TNU version #4784

merged 5 commits into from
Sep 18, 2024

Conversation

LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Sep 16, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-5056

Summary of changes

What

Why

  • TNU released a new version, and since this package is installed in the base image, all children images needed to be regenerated as well

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (4ad7058) to head (f5bf7ba).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4784   +/-   ##
========================================
  Coverage    74.79%   74.79%           
========================================
  Files          165      165           
  Lines        14946    14946           
  Branches      1178     1178           
========================================
  Hits         11179    11179           
  Misses        3767     3767           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad7058...f5bf7ba. Read the comment docs.

@LizBaldo LizBaldo marked this pull request as ready for review September 18, 2024 12:54
welder_server="us.gcr.io/broad-dsp-gcr-public/welder-server:8667bfe"
openidc_proxy="broadinstitute/openidc-proxy:2.3.1_2"
anvil_rstudio_bioconductor="us.gcr.io/broad-dsp-gcr-public/anvil-rstudio-bioconductor:3.19.0"

# Note that this is the version used currently by AOU in production, the one above can be staged for testing
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.7"
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.13"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is AOU ready for this update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, sorry I should have left a breadcrumb, but AOU has been using 2.13 in prod for a few months now, so this should not change anything and we can tell them to start testing for 2.14 in pre-prod. 2.2.7 was just gathering dust for nothing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qi77Qi could you confirm that our pro and pre-prod versions of the AOU image are correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LizBaldo LizBaldo merged commit b093874 into develop Sep 18, 2024
23 checks passed
@LizBaldo LizBaldo deleted the IA-5056-update-TNU branch September 18, 2024 17:34
jgainerdewar added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants