-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IA-5056] Update TNU version #4784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4784 +/- ##
========================================
Coverage 74.79% 74.79%
========================================
Files 165 165
Lines 14946 14946
Branches 1178 1178
========================================
Hits 11179 11179
Misses 3767 3767 Continue to review full report in Codecov by Sentry.
|
welder_server="us.gcr.io/broad-dsp-gcr-public/welder-server:8667bfe" | ||
openidc_proxy="broadinstitute/openidc-proxy:2.3.1_2" | ||
anvil_rstudio_bioconductor="us.gcr.io/broad-dsp-gcr-public/anvil-rstudio-bioconductor:3.19.0" | ||
|
||
# Note that this is the version used currently by AOU in production, the one above can be staged for testing | ||
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.7" | ||
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is AOU ready for this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, sorry I should have left a breadcrumb, but AOU has been using 2.13 in prod for a few months now, so this should not change anything and we can tell them to start testing for 2.14 in pre-prod. 2.2.7 was just gathering dust for nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qi77Qi could you confirm that our pro and pre-prod versions of the AOU image are correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucymcnatt confirming that AOU prod is on 2.13 already: https://github.com/all-of-us/workbench/blob/7f4639e9334bbc3526c2a7676b13d585b23cb541/api/config/config_prod.json#L15
This reverts commit b093874.
Jira ticket: https://broadworkbench.atlassian.net/browse/IA-5056
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.