Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update golang to 1.22 #553

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jul 22, 2024

We need to start using golang 1.22 to consume dependency updates for
openshift/client-go.

@openshift-ci openshift-ci bot requested review from mrogers950 and xiaojiey July 22, 2024 14:24
@rhmdnd rhmdnd requested review from yuumasato and Vincent056 and removed request for mrogers950 July 22, 2024 14:25
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:553

@rhmdnd
Copy link
Author

rhmdnd commented Jul 22, 2024

/retest-required

We need to start using golang 1.22 to consume dependency updates for
openshift/client-go.
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:553

@rhmdnd
Copy link
Author

rhmdnd commented Jul 23, 2024

/retest-required

Rechecking again to see if CI has pulled in the required image we need for golang 1.22.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 23, 2024

/retest-required

@rhmdnd
Copy link
Author

rhmdnd commented Jul 23, 2024

Looks like CI is still pulling in the older golang version, which is what's causing the failures.

Copy link

openshift-ci bot commented Jul 23, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 06ea1db link true /test verify
ci/prow/unit 06ea1db link true /test unit
ci/prow/e2e-rosa 06ea1db link true /test e2e-rosa
ci/prow/e2e-aws-parallel 06ea1db link true /test e2e-aws-parallel
ci/prow/e2e-aws-serial 06ea1db link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
let's merge this to fix the golang tag

Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Author

rhmdnd commented Jul 24, 2024

/override

Copy link

openshift-ci bot commented Jul 24, 2024

@rhmdnd: /override requires failed status contexts to operate on, but none was given

In response to this:

/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhmdnd rhmdnd merged commit 6a21b94 into ComplianceAsCode:master Jul 24, 2024
8 of 14 checks passed
rhmdnd added a commit to rhmdnd/release that referenced this pull request Jul 25, 2024
We recently updated the Dockerfiles in
ComplianceAsCode/compliance-operator to use golang 1.22 and OCP 4.17,
which were then sync'd to openshift/release:

  - ComplianceAsCode/compliance-operator#553
  - openshift#54786

This commit updates the remaining golang version in our configuration to
use golang 1.22.
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Jul 25, 2024
We recently updated the Dockerfiles in
ComplianceAsCode/compliance-operator to use golang 1.22 and OCP 4.17,
which were then sync'd to openshift/release:

  - ComplianceAsCode/compliance-operator#553
  - #54786

This commit updates the remaining golang version in our configuration to
use golang 1.22.
@rhmdnd rhmdnd mentioned this pull request Jan 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants