-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 update golang to 1.22 #553
Conversation
🤖 To deploy this PR, run the following command:
|
/retest-required |
We need to start using golang 1.22 to consume dependency updates for openshift/client-go.
🤖 To deploy this PR, run the following command:
|
/retest-required Rechecking again to see if CI has pulled in the required image we need for golang 1.22. |
/retest-required |
Looks like CI is still pulling in the older golang version, which is what's causing the failures. |
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
let's merge this to fix the golang tag
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override |
@rhmdnd: /override requires failed status contexts to operate on, but none was given In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We recently updated the Dockerfiles in ComplianceAsCode/compliance-operator to use golang 1.22 and OCP 4.17, which were then sync'd to openshift/release: - ComplianceAsCode/compliance-operator#553 - openshift#54786 This commit updates the remaining golang version in our configuration to use golang 1.22.
We recently updated the Dockerfiles in ComplianceAsCode/compliance-operator to use golang 1.22 and OCP 4.17, which were then sync'd to openshift/release: - ComplianceAsCode/compliance-operator#553 - #54786 This commit updates the remaining golang version in our configuration to use golang 1.22.
We need to start using golang 1.22 to consume dependency updates for
openshift/client-go.