Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang Docker tag to v1.23 #598

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Update golang Docker tag to v1.23 #598

merged 2 commits into from
Jan 9, 2025

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Aug 17, 2024

This PR contains the following updates:

Package Type Update Change
golang stage minor 1.22 -> 1.23

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

openshift-ci bot commented Aug 17, 2024

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:598-0233a442fb5cce4925d527f4e98b4a90c807535c

@rhmdnd
Copy link

rhmdnd commented Aug 20, 2024

/hold

@rhmdnd rhmdnd requested review from yuumasato and Vincent056 and removed request for jhrozek and mrogers950 August 20, 2024 16:26
@renovate renovate bot changed the title Update golang Docker tag to v1.23 chore(deps): update golang docker tag to v1.23 Aug 29, 2024
@rhmdnd rhmdnd added this to the 1.6.1 milestone Oct 11, 2024
@renovate renovate bot changed the title chore(deps): update golang docker tag to v1.23 Update golang Docker tag to v1.23 Nov 27, 2024
@rhmdnd rhmdnd modified the milestones: 1.6.1, 1.7.0 Jan 7, 2025
Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign jhrozek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Author

renovate bot commented Jan 7, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

github-actions bot commented Jan 7, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:598-6e238e075c4a4d0c3278cabd465369f15fc54b7f

@rhmdnd
Copy link

rhmdnd commented Jan 7, 2025

I believe this is failing because we're still using a golang 1.22 image in CI:

 INFO[2025-01-07T17:53:24Z] go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
GOFLAGS=-mod=vendor GO111MODULE=auto go vet 
go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
make: *** [Makefile:308: vet] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-01-07T17:53:24Z"} 

That image is maintained by automation that syncs the image based on what's in the compliance-operator repository:

openshift/release@d7e170f

@rhmdnd
Copy link

rhmdnd commented Jan 7, 2025

I believe this is failing because we're still using a golang 1.22 image in CI:

 INFO[2025-01-07T17:53:24Z] go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
GOFLAGS=-mod=vendor GO111MODULE=auto go vet 
go: go.mod requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
make: *** [Makefile:308: vet] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-01-07T17:53:24Z"} 

That image is maintained by automation that syncs the image based on what's in the compliance-operator repository:

openshift/release@d7e170f

We hit the same issue with #553

Copy link

github-actions bot commented Jan 7, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:598-51ee800d3c6b2737aa4e731f165a431df33032e7

@rhmdnd rhmdnd force-pushed the renovate/golang-1.x branch from 51ee800 to 4f27424 Compare January 9, 2025 17:10
Copy link

github-actions bot commented Jan 9, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:598-4f274240154613f16304260416cefd8599204c6a

Copy link

openshift-ci bot commented Jan 9, 2025

@renovate[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 4f27424 link true /test verify
ci/prow/unit 4f27424 link true /test unit
ci/prow/e2e-aws-serial 4f27424 link true /test e2e-aws-serial
ci/prow/e2e-rosa 4f27424 link true /test e2e-rosa
ci/prow/e2e-aws-parallel 4f27424 link true /test e2e-aws-parallel
ci/prow/images 4f27424 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link

rhmdnd commented Jan 9, 2025

Kicking this through so repository automation can update the image reference we use in openshift/release https://github.com/openshift/release/blob/master/ci-operator/config/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master.yaml#L10

@rhmdnd rhmdnd merged commit 769f01e into master Jan 9, 2025
9 of 16 checks passed
@rhmdnd rhmdnd deleted the renovate/golang-1.x branch January 9, 2025 18:09
rhmdnd added a commit to rhmdnd/release that referenced this pull request Jan 9, 2025
We recently updated the golang version in our project to 1.23:

  ComplianceAsCode/compliance-operator#598

This commit updates the last reference in the CI configuration to use
1.23 as well.
rhmdnd added a commit to rhmdnd/release that referenced this pull request Jan 9, 2025
We recently updated the golang version in our project to 1.23:

  ComplianceAsCode/compliance-operator#598

This commit updates the last reference in the CI configuration to use
1.23 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants