Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow new items to use legacy int to_hit #74597

Merged
merged 26 commits into from
Jul 20, 2024
Merged

Don't allow new items to use legacy int to_hit #74597

merged 26 commits into from
Jul 20, 2024

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

Closes #74563

Describe the solution

Adds a test with blacklist that flags any new items being added using the legacy method.
Changes the default to_hit to -2 as intended and remove all explicit -2 to_hit
Adds to_hit to various "weapons" lacking it so that the default change doesn't unintentionally nerf them
Adds initial blacklists for vanilla and all repo mods that need updating, deals with mods with very few issues now rather than adding them to blacklists

Describe alternatives you've considered

Keeping legacy stuff around forever

Testing

Ran the test on every in repo mod separately
Ran a seperate (not included) test to determine "weapons" lacking to_hit to determine where it needed manually adding due to the default change

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Items: Battery / UPS Electric power management Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Markdown] Markdown issues and PRs Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Melee Melee weapons, tactics, techniques, reach attack Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Generic Guns Anything to do with Generic Guns Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Items: Containers Things that hold other things Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing Appliance/Power Grid Anything to do with appliances and power grid Mods: No Hope Relating to the mod No Hope labels Jun 16, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 16, 2024
@github-actions github-actions bot added the Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons label Jun 22, 2024
@BalthazarArgall BalthazarArgall mentioned this pull request Jun 24, 2024
Merged
@Maleclypse
Copy link
Member

well that's madness. the tests failed on the american 180 and hk_mp5 but neither of them are in your files at all

@Procyonae
Copy link
Contributor Author

Ye this is kind of annoying bc peeps keep doing gun removals/renames that are moving stuff around

@Procyonae Procyonae mentioned this pull request Jun 29, 2024
Merged
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 20, 2024
@kevingranade kevingranade merged commit 761431e into CleverRaven:master Jul 20, 2024
22 of 27 checks passed
@GuardianDll GuardianDll deleted the EnforceNewToHit branch July 20, 2024 22:19
This was referenced Jul 20, 2024
Merged
Merged
@Karol1223 Karol1223 mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karol1223 Karol1223 Karol1223 requested changes

@GuardianDll GuardianDll GuardianDll left review comments

Assignees
No one assigned
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Battery / UPS Electric power management Items: Containers Things that hold other things Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Mods: Backrooms Mods: Defense Mode Anything to do with the Defense Mode mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Generic Guns Anything to do with Generic Guns Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: No Hope Relating to the mod No Hope Mods: Tamable Wildlife Mods: Xedra Evolved Anything to do with Xedra Evolved Monsters Monsters both friendly and unfriendly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Begin enforcing the new to-hit syntax
5 participants
@Procyonae @Maleclypse @GuardianDll @Karol1223 @kevingranade