-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the S&W 619 with the 686 Plus #74756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Jun 24, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
the
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
label
Jun 24, 2024
Co-authored-by: DoctorBoomstick <[email protected]>
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Generic Guns
Anything to do with Generic Guns
labels
Jun 26, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 26, 2024
github-actions
bot
added
Spawn
Creatures, items, vehicles, locations appearing on map
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
labels
Jun 28, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Jun 28, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 28, 2024
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Generic Guns
Anything to do with Generic Guns
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The S&W model 619 is such a rare gun that it has 0 hits on gunbroker open listings, removal?
Describe the solution
While the model 619 is insanely rare, the very similar model 686 is quite common, I think renaming the item and changing the values to match is perfectly appropriate. The specific variant is the Model 686 "Plus" so it matches the amount of bullets in the cylinder of the 619 while still being common enough to be included.
While I was at it I also removed the semi-obsolete melee values and a comment.
Describe alternatives you've considered
Testing
None.
Additional context
686 "Plus" listings on gunbroker:
@Holli-Git Did the thing, you can take it off the list. o7