Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the S&W 619 with the 686 Plus #74756

Merged
merged 13 commits into from
Jun 28, 2024

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jun 24, 2024

Summary

None

Purpose of change

The S&W model 619 is such a rare gun that it has 0 hits on gunbroker open listings, removal?

Describe the solution

While the model 619 is insanely rare, the very similar model 686 is quite common, I think renaming the item and changing the values to match is perfectly appropriate. The specific variant is the Model 686 "Plus" so it matches the amount of bullets in the cylinder of the 619 while still being common enough to be included.

While I was at it I also removed the semi-obsolete melee values and a comment.

Describe alternatives you've considered

  • Remove the 619 gasp.
  • Implement the "base", more common 686 model and make the clip size 6.
  • Remove the comment about the OAL stuff and make the barrel length 150mm, this has almost no impact but I decided to follow "good practices".

Testing

None.

Additional context

686 "Plus" listings on gunbroker:
Untitled

@Holli-Git Did the thing, you can take it off the list. o7

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 24, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Introduced in the 90's, the Smith & Wessons's model 686 'Plus' features a robust stainless steel frame, an adjustable front sight and a seventh shot that's sure to save your life.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@BalthazarArgall BalthazarArgall marked this pull request as draft June 24, 2024 14:01
@BalthazarArgall BalthazarArgall marked this pull request as draft June 24, 2024 14:01
@github-actions github-actions bot added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label Jun 24, 2024
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Generic Guns Anything to do with Generic Guns labels Jun 26, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 26, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review June 26, 2024 16:44
@github-actions github-actions bot added Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Jun 28, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jun 28, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 28, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 28, 2024
@Maleclypse Maleclypse merged commit 54bd595 into CleverRaven:master Jun 28, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants