Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Magiclysm validation to Basic Build #75132

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Jul 20, 2024

Summary

None

Purpose of change

In #74597 I noticed the magiclysm checks were happening way down the list in the alternate compiler builds, this is supposed to be happening in Basic Build.

Describe the solution

Moved --mods=magiclysm to the Basic Build entry.

Additional Context

This needs to be rebased on top of #75131 to pass Basic Build.

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 20, 2024
@Maleclypse Maleclypse merged commit 591d326 into master Jul 24, 2024
21 checks passed
@Maleclypse Maleclypse deleted the validate-magiclysm-in-basic-build branch July 24, 2024 02:31
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants