-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update wordpress monorepo #42835
Conversation
FYI @sgomes — was it so that with this we can remove the Webpack stuff handling dashicons removal? |
@simison These versions include the These changes should also bring savings elsewhere, like dropping |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~116 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~2439 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~6593 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~158 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Looks like the Still running tests to see what happens when we remove the |
@sirreal Looks like we can't ditch the hack just yet. And |
Having trouble figuring out what's going on with the bundle while the |
39ae0ed
to
371e91c
Compare
@scinos do you know what's up with Yarn/NPM here? #42835 (comment) |
Looks like a problem in Renovate side. I can see this in their logs:
I'd say wait for the next execution (it runs every hour) and see if Renovate updates this PR. |
c7f5b5d
to
7d1157e
Compare
8997924
to
c671782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wp-desktop CI is failing - there's a chance this branch needs re-basing on latest Calypso master as there was a recent runtime issue that was fixed a couple days ago.
A large number of dependencies have been updated in this PR, and I think we need to be doubly-sure that no runtime issues are introduced into the desktop prior to merging.
Update: just checked "Rebase/Retry".
Update: Latest Calypso master is building with wp-desktop, but looks like there is a legitimate build/runtime error introduced by this PR (see comment below).
c671782
to
6d30e15
Compare
One suggestion to move these changes forward is to manually group/stagger the changes - might make it easier to isolate the problem(s). |
db64082
to
4acf7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress Desktop CI Failure for job "wp-desktop-source".
@ please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".
Please also ensure this branch is rebased off latest Calypso.
8d04b83
to
24de579
Compare
Since Renovate keeps stomping over my changes, here's the diff that's needed on top of the package updates (in case it happens again): diff --git a/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-item/style.scss b/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-item/style.scss
index a0b4ab41b6..70f9f537e8 100644
--- a/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-item/style.scss
+++ b/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-item/style.scss
@@ -8,7 +8,7 @@
width: 100%;
height: auto;
margin: 0;
- padding: ($panel-padding / 2) $panel-padding;
+ padding: ( $grid-unit-20 / 2 ) $grid-unit-20;
text-align: initial;
color: $white;
@@ -23,7 +23,7 @@
box-shadow: none !important;
outline: none !important;
border-radius: 0;
- padding: ( ( $panel-padding / 2 ) - 1 ) ( $panel-padding - 1 );
+ padding: ( ( $grid-unit-20 / 2 ) - 1 ) ( $grid-unit-20 - 1 );
}
&.is-selected {
@@ -50,7 +50,7 @@
.wpcom-block-editor-nav-item__label {
display: inline-block;
padding: 4px;
- border-radius: $radius-round-rectangle;
+ border-radius: $radius-block-ui;
background: $dark-gray-500;
font-weight: 600;
margin-left: 4px;
diff --git a/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-sidebar/style.scss b/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-sidebar/style.scss
index a60d4c2fb4..8551f1eaa4 100644
--- a/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-sidebar/style.scss
+++ b/apps/full-site-editing/full-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/nav-sidebar/style.scss
@@ -68,7 +68,7 @@ $transition-period: 100ms;
}
.wpcom-block-editor-nav-sidebar-nav-sidebar__site-title {
- padding: 8px 16px;
+ padding: 8px 16px;
margin-top: 14px;
h2 {
@@ -116,7 +116,7 @@ $transition-period: 100ms;
}
.wpcom-block-editor-nav-sidebar-nav-sidebar__list-heading {
- padding: $panel-padding;
+ padding: $grid-unit-20;
font-size: $big-font-size;
color: $white;
}
diff --git a/apps/o2-blocks/package.json b/apps/o2-blocks/package.json
index 5f6e87a6c5..261a97482d 100644
--- a/apps/o2-blocks/package.json
+++ b/apps/o2-blocks/package.json
@@ -23,6 +23,7 @@
},
"dependencies": {
"@wordpress/api-fetch": "^3.18.0",
+ "@wordpress/base-styles": "^2.0.1",
"@wordpress/block-editor": "^4.3.3",
"@wordpress/blocks": "^6.20.3",
"@wordpress/components": "^10.0.3",
diff --git a/apps/o2-blocks/src/todo/editor.scss b/apps/o2-blocks/src/todo/editor.scss
index 7638e00787..2db555e61c 100644
--- a/apps/o2-blocks/src/todo/editor.scss
+++ b/apps/o2-blocks/src/todo/editor.scss
@@ -1,24 +1,4 @@
-// Hugo's new WordPress shades of gray
-// from http://codepen.io/hugobaeta/pen/grJjVp
-$black: #000;
-$dark-gray-900: #191e23;
-$dark-gray-800: #23282d;
-$dark-gray-700: #32373c;
-$dark-gray-600: #40464d;
-$dark-gray-500: #555d66; // use this most of the time for dark items
-$dark-gray-400: #606a73;
-$dark-gray-300: #6c7781;
-$dark-gray-200: #7e8993;
-$dark-gray-100: #8f98a1;
-$light-gray-900: #a2aab2;
-$light-gray-800: #b5bcc2;
-$light-gray-700: #ccd0d4;
-$light-gray-600: #d7dade;
-$light-gray-500: #e2e4e7; // good for "grayed" items and borders
-$light-gray-400: #e8eaeb;
-$light-gray-300: #edeff0;
-$light-gray-200: #f3f4f5;
-$light-gray-100: #f8f9f9;
+@import '~@wordpress/base-styles/colors';
$color-accent-green: #31843f;
@@ -33,7 +13,7 @@ $color-accent-green: #31843f;
// Individual to-do list item.
.wp-block-a8c-todo__item {
- border-bottom: 1px solid $light-gray-500;
+ border-bottom: 1px solid $gray-200;
display: flex;
justify-content: space-between;
padding: 4px 0;
@@ -43,7 +23,7 @@ $color-accent-green: #31843f;
.item-status {
display: inline-block;
content: '';
- border: 1px solid $light-gray-500;
+ border: 1px solid $gray-200;
border-radius: 50%;
margin: 7px 8px 0 0;
height: 16px;
@@ -85,14 +65,14 @@ $color-accent-green: #31843f;
border-radius: 4px;
box-shadow: none;
background: none;
- color: $light-gray-500;
+ color: $gray-200;
.dashicon {
- fill: $light-gray-500;
+ fill: $gray-200;
}
&:hover {
- border-color: $light-gray-200;
+ border-color: $gray-100;
.dashicon {
fill: $dark-gray-500;
@@ -108,7 +88,7 @@ $color-accent-green: #31843f;
font-size: 13px !important; // yep, I'm a monster.
color: $dark-gray-500;
border: 1px solid $light-gray-700;
- background: $light-gray-200;
+ background: $gray-100;
box-shadow: 0 1px 0 $light-gray-700;
margin: 0;
height: 33px;
@@ -123,10 +103,7 @@ $color-accent-green: #31843f;
display: inline;
}
}
-
}
-
-
}
// We need to be super-specific here to be sure we're overwriting the default UL styling.
@@ -148,7 +125,6 @@ body:not( .wp-admin ) .gutenberg {
}
}
-
// Only show the "add new" form when it's strictly needed.
.wp-block-a8c-todo .add-new-todo-item-form {
display: none;
diff --git a/client/assets/stylesheets/gutenboarding.scss b/client/assets/stylesheets/gutenboarding.scss
index ea1199b6b6..4c46f230a2 100644
--- a/client/assets/stylesheets/gutenboarding.scss
+++ b/client/assets/stylesheets/gutenboarding.scss
@@ -15,7 +15,7 @@
// Change loading logo's color while Calypso boots
.wpcom-site__logo {
- fill: $light-gray-500;
+ fill: $gray-200;
}
// Hide Calypso header while Calypso boots
diff --git a/client/landing/gutenboarding/components/domain-picker-button/style.scss b/client/landing/gutenboarding/components/domain-picker-button/style.scss
index fa35476282..5c59dc2807 100644
--- a/client/landing/gutenboarding/components/domain-picker-button/style.scss
+++ b/client/landing/gutenboarding/components/domain-picker-button/style.scss
@@ -22,7 +22,7 @@
&.components-button {
@include onboarding-medium-text;
background: var( --studio-blue-0 );
- border-radius: $radius-round-rectangle;
+ border-radius: $radius-block-ui;
color: var( --studio-blue-40 );
max-width: 100%;
height: auto; // prevent clipping when there are 2 lines
diff --git a/client/landing/gutenboarding/components/header/style.scss b/client/landing/gutenboarding/components/header/style.scss
index 6d573e256c..711217101b 100644
--- a/client/landing/gutenboarding/components/header/style.scss
+++ b/client/landing/gutenboarding/components/header/style.scss
@@ -34,7 +34,7 @@ $padding--gutenboarding__header: $grid-unit-10;
display: flex;
align-items: center;
justify-content: space-between;
- border-bottom: 1px solid $light-gray-500;
+ border-bottom: 1px solid $gray-200;
height: $onboarding-header-height;
background: $white;
z-index: onboarding-z-index( '.onboarding__header' );
@@ -59,7 +59,7 @@ $padding--gutenboarding__header: $grid-unit-10;
display: inline-block;
padding: 1px 8px;
margin: 0 4px;
- border: 1px solid $light-gray-500;
+ border: 1px solid $gray-200;
text-transform: uppercase;
}
diff --git a/client/landing/gutenboarding/onboarding-block/acquire-intent/style.scss b/client/landing/gutenboarding/onboarding-block/acquire-intent/style.scss
index 2c3e466bbb..805b3735ae 100644
--- a/client/landing/gutenboarding/onboarding-block/acquire-intent/style.scss
+++ b/client/landing/gutenboarding/onboarding-block/acquire-intent/style.scss
@@ -97,7 +97,7 @@
.acquire-intent--with-skip {
.site-title__input::after {
- background-image: linear-gradient( to right, $light-gray-700, $light-gray-200 );
+ background-image: linear-gradient( to right, $light-gray-700, $gray-100 );
}
}
diff --git a/packages/onboarding/src/action-buttons/style.scss b/packages/onboarding/src/action-buttons/style.scss
index 5d6c370164..87831d099f 100644
--- a/packages/onboarding/src/action-buttons/style.scss
+++ b/packages/onboarding/src/action-buttons/style.scss
@@ -4,7 +4,7 @@
.action-buttons {
padding: 0 20px;
- border-top: 1px solid $light-gray-500;
+ border-top: 1px solid $gray-200;
background-color: $white;
position: fixed;
bottom: 0;
diff --git a/packages/onboarding/styles/mixins.scss b/packages/onboarding/styles/mixins.scss
index feab18a8ee..9247234985 100644
--- a/packages/onboarding/styles/mixins.scss
+++ b/packages/onboarding/styles/mixins.scss
@@ -165,7 +165,7 @@
// onaboarding-placeholder() mixin is a copy of 'client/assets/stylesheets/shared/mixins/placeholder'
-@mixin onboarding-placeholder( $color-property: $light-gray-200 ) {
+@mixin onboarding-placeholder( $color-property: $gray-100 ) {
animation: onboarding-loading-pulse 1.6s ease-in-out infinite;
background: $color-property;
color: transparent; |
This is due to form controls resets being no longer implicitly included: WordPress/gutenberg#22596. The fix is to include the relevant SASS mixin in our styling. Furthermore, the radio control mixin's border was changed here: https://github.com/WordPress/gutenberg/pull/23578/files#diff-ee60c2980a3c80e299c9495839db403eR353. The fix is to explicitly compute the relevant dimensions. Commit coming right up. |
96ac446
to
48680ee
Compare
e2e tests still failing. Judging from the logs, I'm pretty sure we've hit the rate limit for account creation. I'll try re-running them tomorrow. |
Looks like Gutenberg made Gutenboarding larger yet again 😞 This time by 7.5KB / 3KB gzipped. |
It looks like this PR may have added a number of duplicates in |
|
The deduplication sadly does not seem to improve things. |
This PR contains the following updates:
^2.9.0
->^2.11.0
^3.15.0
->^3.18.0
^2.5.0
->^2.7.0
^3.5.0
->^3.7.0
^1.8.0
->^1.11.0
^1.8.0
->^1.11.0
1.9.0
->1.11.0
^1.9.0
->^1.12.0
^3.11.0
->^4.2.0
^2.18.0
->^2.21.0
^6.16.0
->^6.19.0
^2.6.0
->^2.7.0
^9.6.0
->^9.9.0
^3.7.0
->^3.18.0
^3.16.0
->^3.18.0
^3.7.2
->^3.18.0
^3.15.0
->^3.18.0
^2.16.0
->^2.19.0
^4.18.0
->^4.21.0
^4.6
->^4.21
^4.18.0
->^4.21.0
^1.4.0
->^1.15.0
^1.12.0
->^1.15.0
^2.4.0
->^2.8.0
^2.6.0
->^2.8.0
^2.9.0
->^2.12.0
^2.9.0
->^2.10.0
^4.7.0
->^4.10.0
^3.17.0
->^3.20.0
^9.16.0
->^9.19.0
^2.14.0
->^2.15.0
^2.14.0
->^2.15.0
1.4.0
->1.6.0
^6.0.0
->^7.1.0
^1.18.0
->^1.21.0
^3.11.0
->^3.14.0
^3.10.0
->^3.14.0
^3.9.0
->^3.14.0
^3.12.0
->^3.14.0
^2.0.0
->^2.3.0
^2.0.0
->^2.1.0
^6.0.0
->^6.2.0
^1.5.0
->^1.8.0
^2.12.0
->^2.14.0
^1.11.0
->^1.14.0
^2.4.0
->^2.7.0
^3.0.0
->^3.1.0
^3.16.0
->^3.19.0
^2.16.0
->^2.19.0
^1.5.0
->^1.6.0
^1.6.0
->^1.7.0
^3.9.0
->^3.10.0
^3.16.0
->^3.19.0
^9.1.0
->^12.0.0
^1.12.0
->^1.15.0
^2.7.0
->^2.9.0
^2.8.2
->^2.17.0
^2.15.0
->^2.17.0
^2.17.0
->^2.20.0
Release Notes
WordPress/gutenberg
v2.11.0
Compare Source
v2.10.0
Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.