Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WordPress.com Editing Toolkit version to 1.15 #44509

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Jul 29, 2020

Changes proposed in this Pull Request

  • Bumps version of the editing toolkit

New Relase notes:

  • Plugin display name changed to WordPress.com Editing Toolkit.
  • The donation block has been removed from the plugin.
  • Improved contrast of links in the navigation sidebar.
  • Add a launch sidebar to the editor to walk the user through the launch flows.
  • Fix formatting of the site title in the navigation sidebar.

Changes included in this release:

Testing instructions

  • Apply D47156-code to your sandbox
  • Check the features included in this release appear in the editor as expected
  • Smoke test the editor on Atomic with and without the Gutenberg plugin enabled

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D47156-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@noahtallen
Copy link
Contributor

thanks for using the new name!

@p-jackson p-jackson force-pushed the update/wpcom-editing-toolkit-1.15 branch 2 times, most recently from 48aaa14 to 73e03c3 Compare July 30, 2020 22:57
@ramonjd ramonjd requested a review from a team July 31, 2020 04:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 31, 2020
@ramonjd
Copy link
Member

ramonjd commented Jul 31, 2020

Sorry @p-jackson we got caught in a last-minute production hotfix and I only got to test one commit

The check icons for the Pick a free domain items has lots of left padding though

Screen Shot 2020-07-31 at 3 07 15 pm

cc @yansern

@p-jackson p-jackson force-pushed the update/wpcom-editing-toolkit-1.15 branch from 73e03c3 to 6b31548 Compare August 2, 2020 23:05
@p-jackson
Copy link
Member Author

I've tested on Atomic and everything works as expected (new launch sidebar doesn't work, but that's because the launch button doesn't exist on Atomic).

The only issue I'm having is when I upload the pre-packaged zip file to an ephemeral site. I use the upload UI and when I activate get the error message "The plugin does not have a valid header."

Screenshot 2020-08-03 at 4 04 33 PM

However if I then try to activate it again from the plugin UI it works. Or, if I try to simulate a plugin upgrade using ftp it also works first time. So I'm not really sure what the issue is. But it makes me a little nervous.

@p-jackson
Copy link
Member Author

Issue tracked down. It was to do with the plugin rename. Fix: #44601

@p-jackson p-jackson force-pushed the update/wpcom-editing-toolkit-1.15 branch from 6b31548 to 947f480 Compare August 3, 2020 21:38
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested uploading and activating plugin after #44601

Works for me.

@p-jackson p-jackson merged commit f26cf7a into master Aug 5, 2020
@p-jackson p-jackson deleted the update/wpcom-editing-toolkit-1.15 branch August 5, 2020 00:05
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants