-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump WordPress.com Editing Toolkit version to 1.15 #44509
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the FSE Plugin on WordPress.com D47156-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
thanks for using the new name! |
48aaa14
to
73e03c3
Compare
Sorry @p-jackson we got caught in a last-minute production hotfix and I only got to test one commit
The check icons for the Pick a free domain items has lots of left padding though cc @yansern |
73e03c3
to
6b31548
Compare
I've tested on Atomic and everything works as expected (new launch sidebar doesn't work, but that's because the launch button doesn't exist on Atomic). The only issue I'm having is when I upload the pre-packaged zip file to an ephemeral site. I use the upload UI and when I activate get the error message "The plugin does not have a valid header." However if I then try to activate it again from the plugin UI it works. Or, if I try to simulate a plugin upgrade using ftp it also works first time. So I'm not really sure what the issue is. But it makes me a little nervous. |
Issue tracked down. It was to do with the plugin rename. Fix: #44601 |
6b31548
to
947f480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested uploading and activating plugin after #44601
Works for me.
Changes proposed in this Pull Request
New Relase notes:
Changes included in this release:
Testing instructions