Remove the plugin header nested inside the editor toolkit #44601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D47453-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
mmtr
approved these changes
Aug 3, 2020
matticbot
removed
the
[Status] Needs Review
|
Thanks for the quick review @mmtr 👍
…On Mon, Aug 3, 2020 at 9:39 PM Miguel Torres ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#44601 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALOMYPUNSWC65KPBXVLOWDR62AT5ANCNFSM4PS7QHMQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activating the 1.15 build of the editing toolkit, WordPress displays a "The plugin nodes not have a valid header" error.
Changes proposed in this Pull Request
/premium-content/premium-content.phpbecause it is not a plugin.It appears that Premium Content began development as a seperate plugin, but then before shipping it was rolled in to
full-site-editing. When WordPress scanspluginsit finds this plugin header and the real one infull-site-editing-plugin.php. Up until now this hasn't been a problem because "Full Site Editing" comes before "Premium Content" in the alphabet.The plugin was renamed in #44499 to "WordPress.com Editing Toolkit". "Premium Content" comes first alphabetically so WordPress tries to use it during plugin activation.
It looks like the plugin header in
/premium-content/premium-content.phpwas only ever used during development so it should be safe to remove.Testing instructions