Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress monorepo #16763

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 8, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@wordpress/annotations 1.12.2 -> 1.24.0 age adoption passing confidence
@wordpress/base-styles 2.0.1 -> 3.3.0 age adoption passing confidence
@wordpress/browserslist-config 2.6.0 -> 2.7.0 age adoption passing confidence
@wordpress/components 9.2.6 -> 12.0.0 age adoption passing confidence
@wordpress/compose 3.11.0 -> 3.23.0 age adoption passing confidence
@wordpress/core-data 2.12.3 -> 2.25.0 age adoption passing confidence
@wordpress/data 4.14.2 -> 4.26.0 age adoption passing confidence
@wordpress/date 3.11.1 -> 3.13.0 age adoption passing confidence
@wordpress/dependency-extraction-webpack-plugin 2.4.0 -> 2.9.0 age adoption passing confidence
@wordpress/e2e-test-utils 4.3.1 -> 4.16.0 age adoption passing confidence
@wordpress/editor 9.12.7 -> 9.25.0 age adoption passing confidence
@wordpress/element 2.18.0 -> 2.19.0 age adoption passing confidence
@wordpress/env 1.6.0 -> 3.0.0 age adoption passing confidence
@wordpress/eslint-plugin 4.0.0 -> 7.4.0 age adoption passing confidence
@wordpress/i18n 3.9.0 -> 3.17.0 age adoption passing confidence
@wordpress/icons 2.7.0 -> 2.9.0 age adoption passing confidence
@wordpress/server-side-render 1.8.6 -> 1.20.0 age adoption passing confidence
@wordpress/url 2.11.0 -> 2.20.0 age adoption passing confidence

Release Notes

WordPress/gutenberg

v1.24.0

Compare Source

v1.23.0

Compare Source

v1.22.0

Compare Source

v1.21.1

Compare Source

v1.21.0

Compare Source

v1.20.4

Compare Source

v1.20.3

Compare Source

v1.20.2

Compare Source

v1.20.1

Compare Source

v1.20.0

Compare Source

v1.19.0

Compare Source

v1.18.0

Compare Source

v1.17.0

Compare Source

v1.16.0

Compare Source

v1.15.0

Compare Source

v1.14.1

Compare Source

v1.14.0

Compare Source

v1.13.0

Compare Source

v1.12.3

Compare Source


Renovate configuration

📅 Schedule: "every weekend" in timezone UTC.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Aug 8, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello renovate[bot]! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D47831-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Aug 8, 2020

Warnings
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes
⚠️ "Testing instructions" are missing for this PR. Please add some

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 412952c

@jeherve
Copy link
Member

jeherve commented Aug 10, 2020

#16687 will help us get rid of a lot of those build errors.

@jeherve jeherve added [Status] Blocked / Hold Build [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 10, 2020
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from e2aae18 to 1c4bfd3 Compare August 15, 2020 00:28
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 1139ec7 to 3ac78c6 Compare August 29, 2020 00:28
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 4516162 to 77036c4 Compare September 12, 2020 00:35
@jeherve
Copy link
Member

jeherve commented Sep 14, 2020

Noting that @brbrr is working on this in #17072

@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 77036c4 to 6878123 Compare September 19, 2020 00:11
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 31f5d95 to e176d65 Compare October 3, 2020 00:53
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from e176d65 to 8a5f7d6 Compare October 10, 2020 00:26
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 2d4fa12 to 7cdf511 Compare October 24, 2020 00:50
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 60180b8 to 6753982 Compare November 7, 2020 00:41
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 6753982 to c08cdd3 Compare November 14, 2020 00:39
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from c08cdd3 to c739d07 Compare November 21, 2020 01:14
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from c739d07 to 1b86883 Compare December 1, 2020 17:41
@ockham
Copy link
Contributor

ockham commented Dec 1, 2020

059b6be might unblock this, for the most part 🤞 See #17072 (comment) for an explanation.

I'm now getting a SASS build related error:

SassError: Undefined variable: "$light-gray-700".

but that doesn't seem to bad. I think we have precedent for this in Calypso (Automattic/wp-calypso#42835?)

@ockham
Copy link
Contributor

ockham commented Jan 11, 2021

  • It looks like extensions/blocks/publicize/twitter/test/options.js is failing because __unstableUseDispatchWithMap is no longer exported (see WordPress/gutenberg#23145)

We should start using @sirreal's awesome @wordpress/no-unsafe-wp-apis lint rule to prevent against cases like these in the future. See p4TIVU-9xW-p2 for more background (and guidelines on how to handle __experimental/__unstable stuff in Automattic products).

@Automattic/jetpack-crew Can y'all file a PR to enable that rule? I'm pretty far away from Jetpack these days

Update, if Jetpack is using the recommended ruleset from @wordpress/eslint-plugin, then an update to the current version of that package should enable that rule automatically (see WordPress/gutenberg#27327).

@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 8b62754 to dfc827c Compare January 23, 2021 01:04
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from dfc827c to 10231b9 Compare January 30, 2021 01:27
@kraftbj
Copy link
Contributor

kraftbj commented Jan 30, 2021

@ockham We don't use the recommended ruleset at this time, but I enabled the unsafe API one in #18624

I'd expect the GitHub action to detail out the blocks that use unsafe APIs right now that we can resolve before merging it in (or agree to add to the exclude list to prevent more unsafe usage).

@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 10231b9 to 43882c3 Compare February 6, 2021 00:19
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Feb 6, 2021
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 43882c3 to 412952c Compare February 13, 2021 03:39
@github-actions github-actions bot added [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 13, 2021
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 412952c to 8d17311 Compare February 20, 2021 01:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

#### Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Please include detailed testing steps, explaining how to test your change, like so:

#### Testing instructions:

* Go to '..'
*

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


Jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 20, 2021
jeherve added a commit that referenced this pull request Feb 22, 2021
Since that block has a set of tests, the tests need to be able to use ToolbarItem. If I update the version of @wordpress/components so it includes ToolbarItem, the tests pass, but the overall block build fails:

    ERROR in ./node_modules/@wp-g2/create-styles/node_modules/postcss/lib/map-generator.js
    Module not found: Error: Can't resolve 'path' in '.../jetpack/node_modules/@wp-g2/create-styles/node_modules/postcss/lib'

Let's consequently hold off this change until @wordpress/components is properly updated in a separate PR: #16763.
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 8d17311 to 1ea7a09 Compare February 27, 2021 01:26
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 1ea7a09 to 191247f Compare March 6, 2021 01:21
@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 191247f to 8cdadcc Compare March 20, 2021 00:14
@anomiex
Copy link
Contributor

anomiex commented Mar 24, 2021

Taking a look again through the stuff that's failing:

  • Tests / PHP tests: PHP 7.2 WP latest: Flaky shortcode test, this would pass on a re-run.
  • Tests / JS tests: Some real stuff here.
    • yarn test-search-size is failing to load a module "@wordpress/dependency-extraction-webpack-plugin/util".
    • yarn test-extensions has a bunch of different failures.
  • Tests / Code coverage: Fails because the JS tests fail.
  • Linting / ESLint (non-excluded files only): There are a bunch of new "Unable to resolve path to module" errors under projects/plugins/jetpack/tests/e2e/.
  • Build / Build all projects: NODE_ENV=production yarn build-search fails, and NODE_ENV=production yarn build-extensions apparently hangs after reporting some errors.
  • Linting / Changelogger use: Just needs a change file added. Can be done easily once everything else passes.
  • The required checks that are showing as "pending" were added recently and should just need a rebase or master merge.

@renovate renovate bot force-pushed the renovate/wordpress-monorepo branch from 8cdadcc to 6203b65 Compare March 24, 2021 20:23
@matticbot
Copy link
Contributor

This renovate PR is too old: renovate loses track of its own PRs when they're beyond the latest 1000 in the repo. See renovate issue #4803.

Closing the PR so renovate can re-create it.

@matticbot matticbot closed this Mar 27, 2021
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 27, 2021
@kraftbj
Copy link
Contributor

kraftbj commented Mar 27, 2021

@anomiex It's interesting that the action closed this right after renovate updated it.

Just happened to reach the criteria or something not as expected?

@anomiex
Copy link
Contributor

anomiex commented Mar 29, 2021

I've been using this PR when testing out renovate stuff, so the branch updates may have been because I forced it.

The whole situation is a bit confusing. Renovate still knows about its branch, and will still update it on schedule or when forced. But it loses track of the PR itself, so it won't link it from its dashboard PR, the "If you want to rebase/retry this PR" checkbox in the PR's description won't work, and instead of updating the PR description it tries (and fails) to create a new PR.

@anomiex anomiex mentioned this pull request Mar 29, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Blocked / Hold [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants