Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @automattic/calypso-build to v6.5.0 #16845

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 15, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@automattic/calypso-build 6.1.0 -> 6.5.0 age adoption passing confidence

Release Notes

Automattic/wp-calypso

v6.5.0

Compare Source

What's Changed

This release contains Calypso updates only (no Electron changes).

v6.4.0

Compare Source

What's New

Fixes
  • Fix "You need to set oauth_client_id in your config file" bug (#​46826)
  • Fix Broken Admin Stats Graphic on Desktop App Boot (#​46621)
Features
  • More responsive native notifications (direct Pinghub connection) (#​46070)

v6.3.0

Compare Source

v6.2.0

Compare Source


Renovate configuration

📅 Schedule: "every weekend" in timezone UTC.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Aug 15, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello renovate[bot]! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D48165-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Aug 15, 2020

Warnings
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against cc28846

@jeherve
Copy link
Member

jeherve commented Aug 17, 2020

Looks like the dependency updates bundled in that update cause our block tests to break.

cc @brbrr

@jeherve jeherve added [Status] Blocked / Hold and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 17, 2020
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch 2 times, most recently from c826956 to 06498f2 Compare August 29, 2020 00:28
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 06498f2 to 614fc33 Compare September 4, 2020 15:38
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 614fc33 to e5281d8 Compare September 12, 2020 00:35
@renovate renovate bot changed the title Update dependency @automattic/calypso-build to v6.2.0 Update dependency @automattic/calypso-build to v6.3.0 Sep 12, 2020
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from e5281d8 to 5700a32 Compare September 19, 2020 00:11
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 5700a32 to 3d3564d Compare September 26, 2020 01:10
@ockham
Copy link
Contributor

ockham commented Oct 5, 2020

@brbrr Could you have a look into this when you can spare some time? It might help unblock the IE11 canary on WP.com 😊 (see Automattic/wp-calypso#41206 (comment) and #17127)

@brbrr
Copy link
Contributor

brbrr commented Oct 6, 2020

Ok, so the tests are passing locally, but for some reason, they are failing with the same error in Travis.

@brbrr
Copy link
Contributor

brbrr commented Oct 6, 2020

Unfortunately, I was not been able to figure out the problem here. What I found:

jest-jasmine (that is shipped together with jest) calls one of the internal jest methods, which apparently does not exists: TypeError: (0 , _testResult.createEmptyTestResult) is not a function

createEmptyTestResult is a method from @jest/test-result

while checking dependencies, I noticed that the latest calypso-build pulling older @jest/test-result version which does not include createEmptyTestResult. It comes from jest-enzyme package. But it was not updated between 6.1.0-6.3.0, The problem not with the package itself.

My guess would be that problem comes from webpack/babel package updates/configs, and unfortunately, I have no idea what might be wrong here.

This conflict was introduced in 6.2.0

@scinos @jsnajdr any idea what might have changed in 6.2.0 release that could affect jest transpilation?

@jsnajdr
Copy link
Member

jsnajdr commented Oct 7, 2020

@brbrr what do I need to run locally to reproduce the issue? There are several kinds of tests and I don't know which is the failing one.

@brbrr
Copy link
Contributor

brbrr commented Oct 7, 2020

@jsnajdr ah, sorry. I should have provided more context upfront

yarn jest extensions would run block related tests that are failing for this PR

@jsnajdr
Copy link
Member

jsnajdr commented Oct 7, 2020

It seems that the Jetpack yarn.lock lockfile is not in a good shape.

The _testResult.createEmptyTestResult is almost certainly caused by two duplicated versions of @jest/test-results. This PR does quite a lot of changes in yarn.lock, so the duplication may be a result of that.

While trying to reproduce with yarn run test-extensions, I encountered two other instances of a similar error, this time with @wordpress/* packages:

  • there was an older version of @wordpress/compose in the tree, one that doesn't support the useInstanceId hook. Tests failed because the export was missing.
  • the @wordpress/data library was duplicated, causing a store (core/blocks) to register in one instance, and then trying to access it from another instance, causing select( 'core/blocks' ).getBlockTypes() to fail (select( 'core/blocks' ) returns null)

@scinos Could we introduce some of the tools that we use in Calypso also to the Jetpack repo? Deduplication, yarn doctor and Calypso doctor...

Probably the best next step here is to properly upgrade and dedupe the @wordpress/* packages.

@brbrr
Copy link
Contributor

brbrr commented Oct 7, 2020

I reverted unrelated changes just in case

@ockham ockham force-pushed the renovate/automattic-calypso-build-6.x branch from 0909e51 to 47cd8a9 Compare October 21, 2020 10:54
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 66c1b2c to a8a6263 Compare October 22, 2020 22:28
@ockham ockham force-pushed the renovate/automattic-calypso-build-6.x branch from a8a6263 to f04504f Compare October 23, 2020 10:34
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch 2 times, most recently from fcf7e28 to 736400c Compare November 7, 2020 00:41
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 736400c to 247f44e Compare November 14, 2020 00:40
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch 2 times, most recently from b9e9df0 to 4722713 Compare November 28, 2020 00:55
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 4722713 to 99b547b Compare November 30, 2020 22:36
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 99b547b to d7818d7 Compare December 1, 2020 17:28
@ockham
Copy link
Contributor

ockham commented Dec 1, 2020

To recap, this likely needs a @wordpress/ monorepo upgrade to unblock it. We have renovate's #16763, but that doesn't work because of a few other required changes that @brbrr worked on in #17072 until we got blocked -- see p9dueE-1Q7-p2.

@renovate renovate bot changed the title Update dependency @automattic/calypso-build to v6.3.0 Update dependency @automattic/calypso-build to v6.5.0 Dec 26, 2020
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from d7818d7 to 004b3da Compare December 26, 2020 00:11
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 004b3da to 50d22a2 Compare January 9, 2021 00:35
@renovate renovate bot force-pushed the renovate/automattic-calypso-build-6.x branch from 50d22a2 to cc28846 Compare January 16, 2021 01:54
@matticbot
Copy link
Contributor

This renovate PR is too old: renovate loses track of its own PRs when they're beyond the latest 1000 in the repo. See renovate issue #4803.

Closing the PR so renovate can re-create it.

@matticbot matticbot closed this Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants